Repository navigation
[HOLD for payment 2021-09-27] Add a scroll bounce or elasticity animation when reaching the top or bottom of a page #4816
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open New Expensify on Android or iOS
- Navigate to a conversation
- Scroll to the top (or scroll a bit upwards and then to the bottom)
Expected Result:
There should be a bounce or elasticity animation when reaching the top or bottom
Actual Result:
No animation is shown when reaching the top or bottom of a page or conversation
Platform:
Where is this issue occurring?
- iOS
- Android
Version Number: 1.0.86-9
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
From @shawnborton https://expensify.slack.com/archives/C01GTK53T8Q/p1629717577129000
FEATURE REQUEST: This might be nit-picky but I noticed that scroll views on iOS don’t have any kind of bounce or elasticity when you reach the end. For example, the list of chats, or any view in Settings, or even when you are viewing a chat with someone. Looks like this is supported in RN via scrollview but not sure how that would work with our implementation?
Activity
MelvinBot commentedon Aug 25, 2021
Triggered auto assignment to @strepanier03 (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.strepanier03 commentedon Aug 27, 2021
OoO, reassigning.
MelvinBot commentedon Aug 27, 2021
Triggered auto assignment to @arielgreen (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.33 remaining items
arielgreen commentedon Sep 7, 2021
@MitchExpensify reassigned to you, this should remain assigned for the duration of the issue.
MitchExpensify commentedon Sep 8, 2021
Ah whoops, thanks for reassigning! Noted
parasharrajat commentedon Sep 10, 2021
@shawnborton What color do we want for the OverScroll Effect on Android?
Here is the video of what I am asking.
effect.mp4
shawnborton commentedon Sep 10, 2021
Maybe the same color we use for our icons or borders? Something that is gray and a bit more subtle, but noticeable. Thoughts on that?
parasharrajat commentedon Sep 10, 2021
Hmm, I would say that works but let me check it.
botify commentedon Sep 14, 2021
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
botify commentedon Sep 15, 2021
🚀 Deployed to staging by @chiragsalian in version: 1.0.98-2 🚀
[-]Add a scroll bounce or elasticity animation when reaching the top or bottom of a page[/-][+][HOLD for payment 2021-09-27] Add a scroll bounce or elasticity animation when reaching the top or bottom of a page[/+]mountiny commentedon Sep 22, 2021
The PR has been deployed to production on Monday 20th September. Updating the title appropriately 🙌
parasharrajat commentedon Sep 28, 2021
Ping for
mountiny commentedon Sep 28, 2021
@parasharrajat You should be paid shortly hopefully!
dylanexpensify commentedon Sep 28, 2021
Payment sent! Job closed!