You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[payment due 9/6][$250] Avatar - Unable to choose profile avatar from library #48242
and it will be resolved once the blur event is triggered. But since there is no navigation happening, the promise is never resolved.
This issue happens after the copilot PR where we move the profile image to profile page.
What changes do you think we should make in order to solve the problem?
We can disable the single execution + wait for navigate thing for the profile image picker by wrapping it with another MenuItemGroup and pass shouldUseSingleExecution as false. This way, the menu item inside the popover menu won't use the single execution logic and will behave like before the copilot PR.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Avatar - Unable to choose profile avatar from library[/-][+][$250] Avatar - Unable to choose profile avatar from library[/+]on Aug 29, 2024
Activity
melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Aug 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The option to select image doesn't show after selecting Upload photo
What is the root cause of that problem?
The profile page is wrapped with MenuItemGroup.
App/src/pages/settings/Profile/ProfilePage.tsx
Lines 147 to 158 in c867918
MenuItemGroup pass down a context of single execution and wait for navigate function.
App/src/components/MenuItemGroup.tsx
Lines 22 to 31 in c867918
When we press Upload photo, it will call single execution and wait for navigate. Single execution will set the
isExecutingstate to trueApp/src/components/MenuItem.tsx
Lines 531 to 540 in c867918
which will disable the menu item.
App/src/components/MenuItem.tsx
Line 583 in c867918
It will be enabled back once the promise of the action passed to
singleExecutionis resolved.App/src/hooks/useSingleExecution/index.native.ts
Lines 26 to 33 in c867918
In our case, the promise is the
waitForNavigate,App/src/hooks/useWaitForNavigation.ts
Lines 27 to 31 in c867918
and it will be resolved once the blur event is triggered. But since there is no navigation happening, the promise is never resolved.
This issue happens after the copilot PR where we move the profile image to profile page.
What changes do you think we should make in order to solve the problem?
We can disable the single execution + wait for navigate thing for the profile image picker by wrapping it with another
MenuItemGroupand passshouldUseSingleExecutionas false. This way, the menu item inside the popover menu won't use the single execution logic and will behave like before the copilot PR.App/src/pages/settings/Profile/ProfilePage.tsx
Lines 157 to 158 in c867918
Or we can do it the hard way by accepting a new props to disable either single execution or wait for navigate or both.
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @yuwenmemon (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Avatar - Unable to choose profile avatar from library[/-][+][$250] Avatar - Unable to choose profile avatar from library[/+]18 remaining items
melvin-bot commentedon Sep 3, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Christinadobrzyn commentedon Sep 3, 2024
Looks like PR was deployed to production on 8/30. Payment day is 9/6. I'm going to be ooo so going to add a BZ teammate to issue payment.
Payouts due:
Contributor: $250 @bernhardoj (offer - https://www.upwork.com/nx/wm/offer/103805189)
Contributor+: $250 @allroundexperts (offer - https://www.upwork.com/nx/wm/offer/103805194)
I think both of you are paid in NewDot? (if not please accept these Upwork offers)
Do we need a regression test?
cc @zanyrenney
bernhardoj commentedon Sep 4, 2024
Yes, I'll request in ND.
zanyrenney commentedon Sep 10, 2024
I don't think we need a regression test for this.
zanyrenney commentedon Sep 10, 2024
Payment summary above closing as both are paid via ND.
bernhardoj commentedon Sep 11, 2024
Requested in ND.
JmillsExpensify commentedon Sep 11, 2024
$250 approved for @bernhardoj
JmillsExpensify commentedon Oct 8, 2024
$250 approved for @allroundexperts