You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Profile - Tapping on "Account name", shows interaction, but no redirection #48253
Version Number: v9.0.26-1 Reproducible in staging?: Y Reproducible in production?: N
Issue was found when executing this PR: #47338 Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Pre: User does NOT have copilot enabled
Access staging.new.expensify.com
Sign into a valid account
Go to Profile > Click on users name at the top
Expected Result:
User expects that if this is not a feature, then no interaction should happen
Actual Result:
The name is clickable (And blinks when clicked) and no redirect happens, when user has copilot enabled, the user can see a dropdown menu here
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
The name is clickable (And blinks when clicked) and no redirect happens, when user has copilot enabled, the user can see a dropdown menu here
What is the root cause of that problem?
Currently, we are using the PressableWithFeedback component to wrap the entire Switcher. Inside PressableWithFeedback, we have the OpacityView component which shows interaction even when the interactive prop is set to false.
What changes do you think we should make in order to solve the problem?
Activity
melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Aug 29, 2024
We think that this bug might be related to #wave-collect - Release 1
Nodebrute commentedon Aug 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tapping on "Account name", shows interaction, but no redirection
What is the root cause of that problem?
By default we have a
pressDimmingValueof 0.8 which is getting applied hereApp/src/components/AccountSwitcher.tsx
Lines 122 to 131 in 8c69c58
What changes do you think we should make in order to solve the problem?
We should pass a prop here
pressDimmingValueand pass the value!canSwitchAccounts ? 1 : undefinedApp/src/components/AccountSwitcher.tsx
Lines 122 to 131 in 8c69c58
Instead of undefined we can also pass 0.8 here
What alternative solutions did you explore? (Optional)
we can also use
!shouldShowDelegatorMenuheredaledah commentedon Aug 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The name is clickable (And blinks when clicked) and no redirect happens, when user has copilot enabled, the user can see a dropdown menu here
What is the root cause of that problem?
Currently, we are using the
PressableWithFeedbackcomponent to wrap the entireSwitcher. InsidePressableWithFeedback, we have theOpacityViewcomponent which shows interaction even when theinteractiveprop is set to false.What changes do you think we should make in order to solve the problem?
Update shouldDim here
App/src/components/Pressable/PressableWithFeedback.tsx
Line 52 in 8c69c58
What alternative solutions did you explore? (Optional)
rushatgabhane commentedon Aug 29, 2024
not a blocker. please assign me
this is under copilot project
8 remaining items
danieldoglas commentedon Sep 2, 2024
@rushatgabhane how's this one going?
melvin-bot commentedon Sep 6, 2024
@danieldoglas, @OfstadC, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
danieldoglas commentedon Sep 6, 2024
@rushatgabhane bump!
rushatgabhane commentedon Sep 6, 2024
fixed in draft PR above ^
OfstadC commentedon Sep 23, 2024
Looks like this was deployed to production. So payment should be issued on 2024-09-26
rushatgabhane commentedon Sep 23, 2024
@OfstadC this is part of copilot project. no payment due
OfstadC commentedon Sep 26, 2024
Perfect! Thanks for confirming @rushatgabhane !