You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Ready for payment] Account switcher - No spacing between account switcher icon and the status icon #48261
Version Number: 9.0.26-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+kh270803a@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Account is a copilot
Account has a very long name
Launch New Expensify app
Go to Account settings
Expected Result:
There will be spacing between account switcher icon and the status icon
Actual Result:
There is no spacing between account switcher icon and the status icon
On Android, the icons overlap with each other
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Hey @VictoriaExpensify! I'm heading out on parental leave so reassigning this! All that's left is paying out @mkhutornyi once he's accepted the offer! Job post found here! TY! 🙇♂️
changed the title [-]Account switcher - No spacing between account switcher icon and the status icon[/-][+][Ready for payment???] Account switcher - No spacing between account switcher icon and the status icon[/+]on Oct 24, 2024
changed the title [-][Ready for payment???] Account switcher - No spacing between account switcher icon and the status icon[/-][+][Ready for payment] Account switcher - No spacing between account switcher icon and the status icon[/+]on Oct 30, 2024
Activity
melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @arosiclair (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
bernhardoj commentedon Aug 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
No spacing between the account switcher and the status button.
What is the root cause of that problem?
We already set a gap to the container so it will have space between the account switcher and the status button.
App/src/pages/settings/InitialSettingsPage.tsx
Lines 365 to 369 in e77f204
However, when the name is really long, it pushes the arrow up & down icon out of the display name box.

What changes do you think we should make in order to solve the problem?
We can set a flex-shrink of 1 to the display name, so when the name is very long, instead of pushing out the icon, the display name will shrink.
App/src/components/AccountSwitcher.tsx
Lines 142 to 146 in e77f204
puneetlath commentedon Aug 29, 2024
demoting since Copilot is under beta cc @rushatgabhane
melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.arosiclair commentedon Aug 29, 2024
Looks like the account switcher was added in #47338. @dangrous can you take a look? @rushatgabhane should probably fix this.
48 remaining items
melvin-bot commentedon Oct 18, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dylanexpensify commentedon Oct 18, 2024
Hey @VictoriaExpensify! I'm heading out on parental leave so reassigning this! All that's left is paying out @mkhutornyi once he's accepted the offer! Job post found here! TY! 🙇♂️
dangrous commentedon Oct 24, 2024
What's the action here? What do we need still to close this out - has payment completed?
[-]Account switcher - No spacing between account switcher icon and the status icon[/-][+][Ready for payment???] Account switcher - No spacing between account switcher icon and the status icon[/+]mkhutornyi commentedon Oct 30, 2024
I already accepted offer.
[-][Ready for payment???] Account switcher - No spacing between account switcher icon and the status icon[/-][+][Ready for payment] Account switcher - No spacing between account switcher icon and the status icon[/+]dangrous commentedon Oct 31, 2024
Got it - so @VictoriaExpensify I think it's up to you to pay out and close!
melvin-bot commentedon Oct 31, 2024
@dangrous, @rushatgabhane, @VictoriaExpensify, @mkhutornyi, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!
VictoriaExpensify commentedon Nov 1, 2024
Sorry, i missed this! Finalising payments now!
VictoriaExpensify commentedon Nov 1, 2024
Payment summary:
@allgandalf paid $250 via Upwork (was already paid)
@mkhutornyi paid $250 via Upwork