Skip to content

[Ready for payment] Account switcher - No spacing between account switcher icon and the status icon #48261

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh270803a@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Account is a copilot
  • Account has a very long name
  1. Launch New Expensify app
  2. Go to Account settings

Expected Result:

There will be spacing between account switcher icon and the status icon

Actual Result:

There is no spacing between account switcher icon and the status icon
On Android, the icons overlap with each other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6585837_1724882296624.ScreenRecording_08-29-2024_05-20-40_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. melvin-bot commented on Aug 29, 2024

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Aug 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. bernhardoj commented on Aug 29, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    No spacing between the account switcher and the status button.

    What is the root cause of that problem?

    We already set a gap to the container so it will have space between the account switcher and the status button.

    <View style={[styles.flexRow, styles.justifyContentBetween, styles.alignItemsCenter, styles.pb3, styles.gap3]}>
    <AccountSwitcher />
    <Tooltip text={translate('statusPage.status')}>
    <PressableWithFeedback
    accessibilityLabel={translate('statusPage.status')}

    However, when the name is really long, it pushes the arrow up & down icon out of the display name box.
    image

    What changes do you think we should make in order to solve the problem?

    We can set a flex-shrink of 1 to the display name, so when the name is very long, instead of pushing out the icon, the display name will shrink.

    <Text
    numberOfLines={1}
    style={[styles.textBold, styles.textLarge]}
    >
    {currentUserPersonalDetails?.displayName}

  4. puneetlath commented on Aug 29, 2024

    @puneetlath
    Contributor

    demoting since Copilot is under beta cc @rushatgabhane

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 29, 2024
  6. melvin-bot commented on Aug 29, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. arosiclair commented on Aug 29, 2024

    @arosiclair
    Contributor

    Looks like the account switcher was added in #47338. @dangrous can you take a look? @rushatgabhane should probably fix this.

  8. 48 remaining items

  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 18, 2024
  10. melvin-bot commented on Oct 18, 2024

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  11. dylanexpensify commented on Oct 18, 2024

    @dylanexpensify
    Contributor

    Hey @VictoriaExpensify! I'm heading out on parental leave so reassigning this! All that's left is paying out @mkhutornyi once he's accepted the offer! Job post found here! TY! 🙇‍♂️

  12. dangrous commented on Oct 24, 2024

    @dangrous
    Contributor

    What's the action here? What do we need still to close this out - has payment completed?

  13. changed the title [-]Account switcher - No spacing between account switcher icon and the status icon[/-] [+][Ready for payment???] Account switcher - No spacing between account switcher icon and the status icon[/+] on Oct 24, 2024
  14. mkhutornyi commented on Oct 30, 2024

    @mkhutornyi
    Contributor

    I already accepted offer.

  15. changed the title [-][Ready for payment???] Account switcher - No spacing between account switcher icon and the status icon[/-] [+][Ready for payment] Account switcher - No spacing between account switcher icon and the status icon[/+] on Oct 30, 2024
  16. dangrous commented on Oct 31, 2024

    @dangrous
    Contributor

    Got it - so @VictoriaExpensify I think it's up to you to pay out and close!

  17. melvin-bot commented on Oct 31, 2024

    @melvin-bot

    @dangrous, @rushatgabhane, @VictoriaExpensify, @mkhutornyi, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. VictoriaExpensify commented on Nov 1, 2024

    @VictoriaExpensify
    Contributor

    Sorry, i missed this! Finalising payments now!

  19. VictoriaExpensify commented on Nov 1, 2024

    @VictoriaExpensify
    Contributor

    Payment summary:
    @allgandalf paid $250 via Upwork (was already paid)
    @mkhutornyi paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions