[HOLD for payment 2024-10-24] [$250] When using the account switcher on iOS there is no safe area

@AndrewGable

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724946621382309

Action Performed:

1.Launch the app and login
2. Tap settings > Account switcher arrows

Expected Result:

No display issues and modal view is scrollable

Actual Result

There is no safe area when using the account switcher

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021831817133463086139
Upwork Job ID: 1831817133463086139
Last Price Increase: 2024-09-05
Automatic offers:

nkdengineer | Contributor | 103922536

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @RachCHopkins

@RachCHopkins

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@rushatgabhane

cc @rushatgabhane on this one

Launch the app

Which app? Hybrid app?

Tap settings > Account switcher arrows

I don't know what this means.

Can we get some more detailed instructions for testing/reproducing, please?

Ok, looks like it's:

Launch the New Expensify app.
Go to Settings > tap username at the top to switch accounts

I can confirm I can't scroll in the list. I'm not sure what "safe area" means, but if I try to select my own account, the app crashes.

@rushatgabhane

Waiting to see what @rushatgabhane has to add here! However this is supposed to work, it's definitely not working like it should.

@rushatgabhane

safe area means the area where default phone interface stuff should be (like in the screenshot, it's overlapping with the wifi symbols, etc.)\

I think we can go ahead and assign @rushatgabhane here for a solution! I can also take this on from the engineering side

@dangrous

@dangrous, @rushatgabhane, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@rushatgabhane

We might want to make this external to clear @rushatgabhane's plate since a contributor should be able to propose

@s77rt

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

use PopoverMenu for account switcher modal #49051

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

@s77rt requires payment through NewDot Manual Requests
@nkdengineer requires payment automatic offer (Contributor)

@s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: Delegate access: Add account switcher #47338
The offending PR has been commented on: Delegate access: Add account switcher #47338 (comment)
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No (edge case)

@nkdengineer

Payment Summary:

Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @s77rt to be paid $250 via NewDot Manual Request
Upwork job here

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

@s77rt

$250 approved for @s77rt

@RachCHopkins

Reopening so @RachCHopkins can complete the BZ checklist. Can you please copy @s77rt's answers to the checklist and finish it out?

@tgolen

Sorry @tgolen I don't understand - there is no regression test for me to set up?

Did you need me to change @s77rt's checklist bullet points to check boxes and tick them?

@RachCHopkins

Sorry, @RachCHopkins. I'm getting my footing on these and I'll be making some improvements to the BZ checklist so that it's more clear and works a little better (see https://github.com/Expensify/Expensify/issues/438990).

I'll just close this for now.

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-24] [$250] When using the account switcher on iOS there is no safe area #48292

Action Performed:

Expected Result:

Actual Result

Workaround:

Platforms:

Screenshots/Videos

64 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-24] [$250] When using the account switcher on iOS there is no safe area #48292

Description

Action Performed:

Expected Result:

Actual Result

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 29, 2024

dangrous commented on Aug 29, 2024

RachCHopkins commented on Aug 30, 2024

RachCHopkins commented on Aug 30, 2024

RachCHopkins commented on Aug 30, 2024

dangrous commented on Aug 30, 2024

melvin-bot commented on Sep 2, 2024

dangrous commented on Sep 3, 2024

64 remaining items

melvin-bot commented on Oct 17, 2024

melvin-bot commented on Oct 17, 2024

s77rt commented on Oct 20, 2024

RachCHopkins commented on Oct 24, 2024

RachCHopkins commented on Oct 24, 2024

JmillsExpensify commented on Oct 24, 2024

tgolen commented on Oct 24, 2024

RachCHopkins commented on Oct 25, 2024

tgolen commented on Oct 25, 2024

tgolen commented on Oct 25, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions