Skip to content

[HOLD for payment 2025-01-13] [$250] iOS Autofill magic code not working #48424

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725292622506979

Action Performed:

  1. Sign in with mobile number on IOS
  2. Wait to receive magic code suggestion in keyboard suggestion
  3. click on suggestion

Expected Result:

Magic code pasted in Input correctly

Actual Result:

Only 1 digit of magic code pasted in Input. Last digit gets pasted in first magic code entry field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

ScreenRecording_08-31-2024.01-04-17_1.MP4
RPReplay_Final1725303564.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834255723519464021
  • Upwork Job ID: 1834255723519464021
  • Last Price Increase: 2024-09-19
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 2, 2024
  2. melvin-bot commented on Sep 2, 2024

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. miljakljajic commented on Sep 9, 2024

    @miljakljajic
    Contributor
  5. m-natarajan commented on Sep 9, 2024

    @m-natarajan
    Author

    Still able to reproduce.

    RPReplay_Final1725916628.MP4
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 12, 2024
  7. melvin-bot commented on Sep 12, 2024

    @melvin-bot
  8. changed the title [-]iOS Autofill magic code not working[/-] [+][$250] iOS Autofill magic code not working[/+] on Sep 12, 2024
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 12, 2024
  10. 51 remaining items

  11. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-13. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @allroundexperts @abekkala @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Jan 7, 2025
  14. abekkala commented on Jan 8, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JAN 13

    • Fix: @hannojg - no payment needed (margelo)
    • PR Review: @allroundexperts [$250, if no regressions] payment via NewDot
      please complete the checklist above
  15. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @hannojg is from an agency-contributor and not due payment
    • Reviewer: @allroundexperts owed $250 via NewDot

    BugZero Checklist (@abekkala)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1834255723519464021/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. abekkala commented on Jan 13, 2025

    @abekkala
    Contributor

    @allroundexperts can you please compelte the checklist above?

  17. allroundexperts commented on Jan 13, 2025

    @allroundexperts
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A (There isn't a single PR responsible for this. It was an edge case that wasn't discovered until now)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/461097

    Regression Test Proposal

    Precondition:

    • On iOS native, make sure you have the mail app installed.
    • You must be logged in to the mail app using the email that has an Expensify account.

    Test:

    1. Open the login screen on a native iOS device
    2. Enter your email address (which you've added to your iOS Mail app)
    3. Once redirected to the OTP screen, open your mail app and wait for the OTP to arrive
    4. Go back to NewDot, wait for mail code to be suggested above the keyboard
    5. Click on the suggested OTP code to auto insert it
    6. Make sure the OTP code gets inserted and the user is logged in

    Do we agree 👍 or 👎

  18. abekkala commented on Jan 14, 2025

    @abekkala
    Contributor

    @allroundexperts can you complete that checklist template?

  19. allroundexperts commented on Jan 14, 2025

    @allroundexperts
    Contributor

    @abekkala All done!

  20. abekkala commented on Jan 15, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY

  21. moved this from Hold for Payment to Done in #expensify-bugson Jan 15, 2025
  22. JmillsExpensify commented on Jun 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions