Skip to content

[HOLD for payment SEPT 23][$250] iOS - 2FA code input is hidden by keyboard when disabling 2FA #48461

New issue
New issue
Closed
Closed
[HOLD for payment SEPT 23][$250] iOS - 2FA code input is hidden by keyboard when disabling 2FA#48461
Assignees
Julesssssabekkalabernhardojalitoshmatov
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@izarutskaya
izarutskaya
opened on Sep 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validation PR #48030
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Launch New Expensify app.
  2. Go to Account settings > Security,
  3. Tap Disable 2FA.

Expected Result:

2FA code input will not be hidden by keyboard when disabling 2FA

Actual Result:

2FA code input is hidden by keyboard when disabling 2FA

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6591193_1725320683828.ScreenRecording_09-03-2024_07-41-10_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831813205395072237
  • Upwork Job ID: 1831813205395072237
  • Last Price Increase: 2024-09-05
  • Automatic offers:
    • alitoshmatov | Reviewer | 103915601
Issue OwnerCurrent Issue Owner: @alitoshmatov

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 3, 2024
  2. melvin-bot
    assigned
    Julesssss
    on Sep 3, 2024

  3. melvin-bot commented on Sep 3, 2024

    @melvin-bot
    melvin-botBot
    on Sep 3, 2024 – with Melvin Bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    abekkala
    on Sep 3, 2024

  5. melvin-bot commented on Sep 3, 2024

    @melvin-bot
    melvin-botBot
    on Sep 3, 2024 – with Melvin Bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Sep 3, 2024

  7. github-actions commented on Sep 3, 2024

    @github-actions
    github-actionsBot
    on Sep 3, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. Julesssss
    added
    DailyKSv2
    and removed
    HourlyKSv2
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    on Sep 3, 2024

  9. 29 remaining items

  10. melvin-bot
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Sep 11, 2024

  11. bernhardoj commented on Sep 11, 2024

    @bernhardoj
    bernhardoj
    on Sep 11, 2024
    Contributor

    PR is ready

    cc: @alitoshmatov

  12. alitoshmatov commented on Sep 17, 2024

    @alitoshmatov
    alitoshmatov
    on Sep 17, 2024
    Contributor

    Deployed to production on 16th

  13. abekkala commented on Sep 20, 2024

    @abekkala
    abekkala
    on Sep 20, 2024
    Contributor

    PAYMENT SUMMARY FOR SEPT 23

  14. abekkala
    changed the title [-][$250] iOS - 2FA code input is hidden by keyboard when disabling 2FA[/-] [+][HOLD for payment SEPT 23][$250] iOS - 2FA code input is hidden by keyboard when disabling 2FA[/+] on Sep 20, 2024

  15. abekkala commented on Sep 23, 2024

    @abekkala
    abekkala
    on Sep 23, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
    • [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
    • [@alitoshmatov] Determine if we should create a regression test for this bug.
    • [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

    @alitoshmatov can you complete checklist so I can issue payment - thank you!

  16. abekkala commented on Sep 26, 2024

    @abekkala
    abekkala
    on Sep 26, 2024
    Contributor

    @alitoshmatov, can you complete the checklist above, please?

  17. abekkala commented on Oct 2, 2024

    @abekkala
    abekkala
    on Oct 2, 2024
    Contributor

    @alitoshmatov just a friendly bump here. Please complete the checklist above and I can issue payment. (before the offer expires in Upwork)

  18. alitoshmatov commented on Oct 6, 2024

    @alitoshmatov
    alitoshmatov
    on Oct 6, 2024
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Require a 2FA code to disable 2FA #48030
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48030/files#r1788965261
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
    • Determine if we should create a regression test for this bug. I think no need since it wasn't regression but rather incomplete feature

  19. alitoshmatov commented on Oct 6, 2024

    @alitoshmatov
    alitoshmatov
    on Oct 6, 2024
    Contributor

    @abekkala Sorry for late response

  20. abekkala commented on Oct 7, 2024

    @abekkala
    abekkala
    on Oct 7, 2024
    Contributor

    @alitoshmatov payment sent and contract ended - thank you! 🎉

  21. abekkala
    closed this as completedon Oct 7, 2024

  22. bernhardoj commented on Oct 7, 2024

    @bernhardoj
    bernhardoj
    on Oct 7, 2024
    Contributor

    Requested in ND.

  23. JmillsExpensify commented on Oct 7, 2024

    @JmillsExpensify
    JmillsExpensify
    on Oct 7, 2024
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions