Repository navigation
[Advanced Approvals] [$250] Web - LHN - Expense report needs to be opened after changing approver to be seen in LHN #48462
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48362
Issue reported by: Applause Internal Team
Action Performed:
Precondition: log into OD as an admin, create a control policy, enable workspace chats, select "Advanced Approvals", invite 3 members (non-admin): 2 approvers and 1 submitter, set the approval flow as submitter submits to approver 1
- Log into ND as submitter
- Navigate to the workspace chat
- Submit an expense
- Log into ND as approver 1
- Navigate to the workspace chat and open the submitted report
- Open any other report in the LHN
- As admin, change the the submitter's submitsTo to approver 2 in OD
- Open the tab with approver 1 logged in
Expected Result:
The approver can still see the expense report in the LHN
Actual Result:
The expense report disappears after changing the approver, and it is not displayed in the LHN unless it is opened in Search, then it stays in the LHN
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6591273_1725327624530.Recording__736.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021833058783152137453
- Upwork Job ID: 1833058783152137453
- Last Price Increase: 2024-09-09
Issue Owner
Current Issue Owner: @chiragsalianMetadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Sep 3, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 3, 2024
@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
RachCHopkins commentedon Sep 5, 2024
Traditionally, workflow is set at the time of submission. If the workflow is changed after submission, this does not affect any reports already submitted. Users must retract a report and submit again to restart with a new workflow.
Has this been changed for New Expensify?
RachCHopkins commentedon Sep 5, 2024
I don't understand the "expected result" here.
Which approver? There are two approvers in the testing workflow.
Disappears for whom? Displayed for whom? There are 3 users involved, is this for all of them?
@IuliiaHerets can we get more specific here, please?
IuliiaHerets commentedon Sep 6, 2024
@RachCHopkins
Expected Result:
The approver 1 can still see the expense report in the LHN
Actual Result:
The expense report disappears from the LHN of approver 1 after admin changes the approver, and it is not displayed in the LHN of approver 1 unless it is opened in Search, then it stays in the LHN approver 1
RachCHopkins commentedon Sep 9, 2024
Thanks @IuliiaHerets - I'll check what the expected behaviour is.
RachCHopkins commentedon Sep 9, 2024
Expected behaviour is that when the approval workflow is changed for a user, this will not affect Processing expenses/reports.
So there should be no change for Approver 1 and Approver 2 should not see anything new.
[-]Web - LHN - Expense report needs to be opened after changing approver to be seen in LHN[/-][+][$250] Web - LHN - Expense report needs to be opened after changing approver to be seen in LHN[/+]33 remaining items
RachCHopkins commentedon Sep 30, 2024
Not overdue. Awaiting a retest.
kavimuru commentedon Oct 1, 2024
Still tester is able to reproduce the issue. This bug was reported from this PR #48362 validation.
Recording.818.mp4
RachCHopkins commentedon Oct 1, 2024
Ok, so going by that, the actual problem is this:
---- Change User 1 approver ----
RachCHopkins commentedon Oct 1, 2024
@chiragsalian that sounds like exactly the thing that you and I could not replicate.
chiragsalian commentedon Oct 4, 2024
The problem you laid out sounds about right Rachael. I'm unable to reproduce it locally or on staging.
RachCHopkins commentedon Oct 8, 2024
Ok well it's pretty hard to fix if no one can reproduce it. I think we should close this until it becomes an issue that can be reproduced. Do you agree @chiragsalian?
chiragsalian commentedon Oct 8, 2024
Yeah thats fine by me. Closing.