[Payment due 8-18][$250] Group - Users with an external domain are displayed as Hidden in the group list

@jjcoffee

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4909728
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

Open NewExpensify app
Log in to the new HT account
Create a group chat with two users bob@domain.com
and alice@domain.com
Open the list of members of the created group

Expected Result:

Users with an external domain should be displayed by email or name in a group list

Actual Result:

Users with an external domain are displayed as Hidden in the group list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6591417_1725344788657.RPReplay_Final1725280032.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0181038d02cba6971d
Upwork Job ID: 1831023091657812719
Last Price Increase: 2024-09-03
Automatic offers:

jjcoffee | Contributor | 103800323
nkdengineer | Contributor | 103829257

Issue Owner

Current Issue Owner: @jjcoffee

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Christinadobrzyn

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users with an external domain should be displayed by email or name in a group list

What is the root cause of that problem?

The problem is here. If a participant does not have a displayName it defaults to the text "Hidden".

What changes do you think we should make in order to solve the problem?

We can simply check if the participant has either a displayName or an email ( eg: login ).
The new version will be :

let displayName = passedPersonalDetails?.displayName ?? passedPersonalDetails?.login ?? '';

What alternative solutions did you explore? (Optional)

Result:

I can reproduce this. This Hidden user has been going on for a while. I don't know if we have another GH related to resolving this - I don't see one. I'm assuming this is a BE fix but adding external for a C+ review first.

Job added to Upwork: https://www.upwork.com/jobs/~0181038d02cba6971d

@jjcoffee

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@nkdengineer

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

monitoring the PR - #48681

@nkdengineer

PR merged 4 days ago so adding a payment due date to this GH. #48681

Payouts due:

Contributor: $250 @nkdengineer (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/38330876/overview)
Contributor+: $250 @jjcoffee (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/38275996/overview)

members, avatar, rename report, settings, default view for other reports

The PR that introduced the bug has been identified. Link to the PR: Update the Group Chat creation flow UI and Details page #39639
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 9dba74f#r146817794
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - this type of thing would be hard to catch in standard PR testing imo
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Create a group chat with two users (bob@domain.com and alice@domain.com)
Open the list of members of the created group
Tap on one of the added users to open the participant details page
Verify that either the user's name, email or Hidden is displayed below the avatar (not an empty space)

Do we agree 👍 or 👎

@Christinadobrzyn

@Christinadobrzyn Friendly bump for payment 🙇

@jjcoffee

Ah thanks for the nudge @jjcoffee!

Regression test - https://github.com/Expensify/Expensify/issues/429387
Payment is initiated in Upwork based on this summary - #48464 (comment)

Closing!

Navigation Menu

Repository navigation

[Payment due 8-18][$250] Group - Users with an external domain are displayed as Hidden in the group list #48464

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Payment due 8-18][$250] Group - Users with an external domain are displayed as Hidden in the group list #48464

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 3, 2024

lanitochka17 commented on Sep 3, 2024

mohamed-iyed-rhimi-1 commented on Sep 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented on Sep 3, 2024

melvin-bot commented on Sep 3, 2024

melvin-bot commented on Sep 3, 2024

17 remaining items

melvin-bot commented on Sep 5, 2024

Christinadobrzyn commented on Sep 11, 2024

Christinadobrzyn commented on Sep 16, 2024

jjcoffee commented on Sep 17, 2024

jjcoffee commented on Sep 19, 2024

Christinadobrzyn commented on Sep 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions