[HOLD for payment 2021-09-28] If you mark a message as unread and close the app or minimize it, the unread status is removed.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open app and login
Open any chat
Long tap any old message
Tap "Mark as Unread"
Force close the app and open it again
Open the same chat as before

Expected Result:

Message is still marked as unread

Actual Result:

Message will lose unread status after force close + reopening

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android ✔️
Desktop App
Mobile Web

Version Number:
1.0.88
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5210356_unread-issue.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

Upwork job link https://www.upwork.com/jobs/~0160911a1308566e83

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Jag96

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Confirmed this is also happening in Prod, removing the deploy blocker label.

@michaelhaxhiu

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

This is not just for force close, this occurs for all activeReports. Whenever, the app visibility changes, the activeReport gets marked as read.

https://reactnative.dev/docs/appstate
Our isVisible implementation for mobile always returns true

App/src/libs/Visibility/index.native.js

Lines 1 to 7 in ae6a754

    
           // Mobile apps do not require this check for visibility as 
        
           // they do not use the Notification lib. 
        
           /** 
        
            * @return {Boolean} 
        
            */ 
        
           const isVisible = () => true;

which leads to always marking the report as read irrespective of visibility changing to active or background

App/src/pages/home/report/ReportActionsView.js

Lines 241 to 248 in 8a5cf2d

    
               /** 
        
                * Records the max action on app visibility change event. 
        
                */ 
        
               onVisibilityChange() { 
        
                   if (Visibility.isVisible()) { 
        
                       updateLastReadActionID(this.props.reportID); 
        
                   } 
        
               }

So, when we mark something as unread and change the app or try to close it, AppState's change event gets triggered, our handler gets triggered, since isVisible is always true, we end up marking the report as read, and hence, we don't get the marker again.

Proposal

Use AppState to get currentState and only return true when the app is active.

function isVisible() {
    return AppState.currentState === 'active';
}

and change onVisibilityChange method to check if app is active and drawer is not open

onVisibilityChange() {
    if (Visibility.isVisible() && !this.props.isDrawerOpen) {
        updateLastReadActionID(this.props.reportID);
    }
}

Issue reproducible during KI retests.

Issue is still in progress, PR is seeing steady progress. Let's keep it up.

PR merged!

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Issue reproducible during KI retests.

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pulls/5155\n- https://github.com/Expensify/App/pulls/5155\n

If no regressions arise, payment will be issued on 2021-09-28. 🎊

Issue not reproducible during KI retests. (Fixed)

Paid!

Navigation Menu

Repository navigation

[HOLD for payment 2021-09-28] If you mark a message as unread and close the app or minimize it, the unread status is removed. #4855

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

34 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Mobile apps do not require this check for visibility as
	// they do not use the Notification lib.

	/**
	* @return {Boolean}
	*/
	const isVisible = () => true;

	/**
	* Records the max action on app visibility change event.
	*/
	onVisibilityChange() {
	if (Visibility.isVisible()) {
	updateLastReadActionID(this.props.reportID);
	}
	}

[HOLD for payment 2021-09-28] If you mark a message as unread and close the app or minimize it, the unread status is removed. #4855

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

OSBotify commented on Aug 26, 2021

MelvinBot commented on Aug 26, 2021

isagoico commented on Aug 26, 2021

MelvinBot commented on Aug 26, 2021

meetmangukiya commented on Aug 27, 2021

Proposal

34 remaining items

isagoico commented on Sep 13, 2021

michaelhaxhiu commented on Sep 15, 2021

Jag96 commented on Sep 15, 2021

botify commented on Sep 15, 2021

isagoico commented on Sep 20, 2021

botify commented on Sep 21, 2021

isagoico commented on Sep 27, 2021

isagoico commented on Oct 4, 2021

Jag96 commented on Oct 4, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions