Skip to content

[$125] Import categories - Unable to dismiss "Import successful" modal by clicking outside the modal #48563

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Distance rates.
  3. Select all distance rates via checkbox.
  4. Click on the dropdown > Delete rates.
  5. Click outside the modal.
  6. Note that the modal can be dismissed by clicking outside the modal.
  7. Go to Categories > 3-dot menu > Import spreadsheet.
  8. Upload a valid file.
  9. Map Name and Enabled.
  10. Click Import.
  11. Click outside the "Import successful" modal to dismiss it.

Expected Result:

"Import successful" modal can be dismissed it by clicking outside the modal.

Actual Result:

"Import successful" modal cannot be dismissed it by clicking outside the modal.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6592722_1725445046306.20240904_181331.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831346879000450861
  • Upwork Job ID: 1831346879000450861
  • Last Price Increase: 2024-09-04
  • Automatic offers:
    • Krishna2323 | Contributor | 103814571
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 4, 2024
  2. melvin-bot commented on Sep 4, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Sep 4, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Sep 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 4, 2024
  6. 19 remaining items

  7. mountiny commented on Sep 5, 2024

    @mountiny
    Contributor

    Payment summary:

    • $125 to @Krishna2323 for the fix
    • no payment to Rushat here as he is going to be paid on the project basis
  8. Krishna2323 commented on Sep 5, 2024

    @Krishna2323
    Contributor

    @rushatgabhane, PR ready for review.

  9. stephanieelliott commented on Sep 7, 2024

    @stephanieelliott
    Contributor

    Hey @rushatgabhane this is blocked on you, can you review the PR when you get a chance?

  10. Guccio163 commented on Sep 9, 2024

    @Guccio163
    Contributor

    PR is merged, I think we can close this one 👌

  11. trjExpensify commented on Sep 10, 2024

    @trjExpensify
    Contributor

    Category import via spreadsheet is being built in #wave-control, moving this over to that project.

  12. stephanieelliott commented on Sep 11, 2024

    @stephanieelliott
    Contributor

    PR is merged to main but not staging yet -- will leave this open to pay out when it's deployed to prod +7

  13. stephanieelliott commented on Sep 24, 2024

    @stephanieelliott
    Contributor

    Hm, this PR was deployed to prod with #48954 on 9/11, but it looks like the automation didn't work. We're past the payment date, setting up payment now.

  14. stephanieelliott commented on Sep 24, 2024

    @stephanieelliott
    Contributor

    Summarizing payment on this issue:

    Upwork job is here: https://www.upwork.com/jobs/~021831346879000450861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions