Skip to content

[$250] 'Recents' contacts when submitting expense does not update #48608

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: n/a
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flodnv
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724228186903849

Action Performed:

  1. Submit an expenses 3 days in a row to the same workspace
  2. Right after the 3rd time, go to submit another expense
  3. Observe that the workspace is still not in 'Recents' (although another workspace is there that I don't even use on NewDot)

Expected Result:

The workspace where I always submit to should be in 'Recents' when using it every day

Actual Result:

I don't see the workspace in 'Recents', I have to type it out every day

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833488575321005184
  • Upwork Job ID: 1833488575321005184
  • Last Price Increase: 2024-09-17
  • Automatic offers:
    • c3024 | Contributor | 104052304
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 4, 2024
  2. melvin-bot commented on Sep 4, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Sep 4, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. twisterdotcom commented on Sep 5, 2024

    @twisterdotcom
    Contributor

    @flodnv are these steps right?

    Submit an expenses 3 days in a row to the same workspace
    Right after the 3rd time, go to submit another expense

    Does it have to be 3 expenses over 3 days?

  5. flodnv commented on Sep 6, 2024

    @flodnv
    Contributor

    No, maybe it's just 1. I used 3 in my example to point out that it's obvious it should be there.

  6. twisterdotcom commented on Sep 10, 2024

    @twisterdotcom
  7. twisterdotcom commented on Sep 10, 2024

    @twisterdotcom
    Contributor

    Put an iOS vid above, but doing a web one now for commentary, this is a real bug that I think is recreatable just by:

    1. Be invited to a Workspace in a normal active Expensify account (that has recent chats)
    2. Submit at expense on that workspace
    3. Submit an expense from the "+" fab
    4. In the "recents" which appear, the workspace doesn't appear at all

    We should absolutely during the "Submit expense" flow especially be prioritising places you have submitted expenses before and Workspace chats overall, over ALL normal chats where no expenses have been shared whatsoever.

    48608.mp4
  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Sep 10, 2024
  9. changed the title [-]'Recents' contacts when submitting expense does not update[/-] [+][$250] 'Recents' contacts when submitting expense does not update[/+] on Sep 10, 2024
  10. 15 remaining items

  11. MariaHCD commented on Sep 19, 2024

    @MariaHCD
    Contributor

    The order that @c3024 suggests sounds good to me:

    I think the order should be like this for Submit Expense flow

    1. Active policy at the top
    2. Sort reports by the time of last money request made
    3. Other workspace chats (where no requests are not made yet)
    4. Others in the order of last activity on the report

    Does this sound good to you, @twisterdotcom ?

  12. twisterdotcom commented on Sep 19, 2024

    @twisterdotcom
    Contributor

    Yeah, this seems logical. I see an argument for switching 2 and 3, but on balance I agree prioritising places you have submitted expenses before is better.

  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 20, 2024
  14. melvin-bot commented on Sep 20, 2024

    @melvin-bot

    📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  15. c3024 commented on Oct 8, 2024

    @c3024
    Contributor

    PR was deployed to production on 1-Oct. Payment is due today!

    cc: @twisterdotcom

  16. twisterdotcom commented on Oct 9, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

  17. Ollyws commented on Oct 10, 2024

    @Ollyws
    Contributor

    Requested in ND.

  18. garrettmknight commented on Oct 15, 2024

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions