Repository navigation
[HOLD for payment 2024-10-07] [$250] Track - Loading spinner appears on a Track your expenses video modal #48650
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a2069@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to FAB> Track
- Verify that video modal appears
Expected Result:
There should be no loading spinner over the video modal
Actual Result:
Loading spinner appears on a Track your expenses video modal and remains to the end of the video
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6593462_1725483841193.Recording__3883.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021832057700758749301
- Upwork Job ID: 1832057700758749301
- Last Price Increase: 2024-09-20
- Automatic offers:
- HezekielT | Contributor | 104122623
Activity
melvin-bot commentedon Sep 5, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Sep 5, 2024
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
nyomanjyotisa commentedon Sep 5, 2024
Edited by proposal-police: This proposal was edited at {current_timestamp}.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Loading spinner appears on a Track your expenses video modal
What is the root cause of that problem?
The loading spinner is controlled by
setIsLoadingand relies onstatus.durationMillishere. And sometime the expo-av video player might not be providing valid values fordurationMillisWhat changes do you think we should make in order to solve the problem?
Update the
setIsLoadinglogic to handle bothdurationMillisandpositionMillis, only set isLoading to true ifstatus.durationMillisis NaN andstatus.positionMillisis 0This ensures that the spinner disappears when the video starts playing
What alternative solutions did you explore? (Optional)
[-]Track - Loading spinner appears on a Track your expenses video modal[/-][+][$250] Track - Loading spinner appears on a Track your expenses video modal[/+]melvin-bot commentedon Sep 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021832057700758749301
melvin-bot commentedon Sep 6, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)bfitzexpensify commentedon Sep 6, 2024
I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.
Current status: waiting on proposals
38 remaining items
mvtglobally commentedon Oct 5, 2024
Issue not reproducible during KI retests. (First week)
bfitzexpensify commentedon Oct 8, 2024
Payment summary:
@HezekielT to be paid $250 for contributor work - @HezekielT, can you confirm the payment via Upwork went through? They've been having some issues processing payments
@hungvu193 to be paid $250 via manual request
garrettmknight commentedon Oct 8, 2024
$250 approved for @hungvu193
HezekielT commentedon Oct 9, 2024
Yes, I have received the payment. Thanks @bfitzexpensify
melvin-bot commentedon Oct 15, 2024
@hungvu193, @bfitzexpensify, @HezekielT, @MarioExpensify Huh... This is 4 days overdue. Who can take care of this?
MarioExpensify commentedon Oct 15, 2024
Hey @bfitzexpensify can we close this one?