Repository navigation
Download file doesn't have the same name as preview #4868
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue is failing PR #4736
Action Performed:
- Navigate to staging chat
- Upload any word document (docx) or non-preview document
- Clicking on download file
Expected Result:
The download file should give the same filename as preview.
Actual Result:
The download file has different name than preview file.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.0.88-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5211160_Name.mp4
Expensify/Expensify Issue URL:
Activity
MelvinBot commentedon Aug 27, 2021
Triggered auto assignment to @ctkochan22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.OSBotify commentedon Aug 27, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:isagoico commentedon Aug 27, 2021
@thienlnam @akshayasalvi I noticed this behaviour was present when working on the PR (mentioned here) Should this still be considered a deploy blocker even if it's failing the PR?
parasharrajat commentedon Aug 27, 2021
ProposalSuggestionfileDownloadmethod.App/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.js
Line 31 in 5e883f3
fileNameis already available as a prop here.akshayasalvi commentedon Aug 27, 2021
Yeah. We were not able to test it from localhost. I had recently added the fileName in the param. I’ll be raising the changes for the pr in a while.
parasharrajat commentedon Aug 27, 2021
Awesome @akshayasalvi. Please tag this issue into your PR as well.
akshayasalvi commentedon Aug 27, 2021
PR Raised and issue tagged.
Julesssss commentedon Aug 27, 2021
Do we know if this is a regression? I can't recall if this was ever working or not. If not let's remove the deployBlocker label.
parasharrajat commentedon Aug 27, 2021
So this is something new and issues are found for a new feature then it's good to push the new feature to the prod with fixes. so I think this justifies as a deployBlocker.
Julesssss commentedon Aug 27, 2021
Oh, didn't notice this was new. Sure, we just don't want to block the release for something that currently exists in prod.
parasharrajat commentedon Aug 27, 2021
But it's already being fixed here #4871 so we can just CP it. Should be quick.
akshayasalvi commentedon Aug 27, 2021
PR is deployed and working.
isagoico commentedon Aug 27, 2021
Fix worked! #4871 (comment) removing the deploy blocker label
ctkochan22 commentedon Aug 27, 2021
Looks like we can close this right? Good job @akshayasalvi
akshayasalvi commentedon Aug 27, 2021
Thank you
botify commentedon Aug 30, 2021
🚀 Deployed to staging by @sketchydroide in version: 1.0.88-3 🚀
botify commentedon Aug 30, 2021
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
botify commentedon Sep 1, 2021
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀