Skip to content

[CVP] Inconsistencies with sending the unread summary email to a newly invited user  #48727

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.29-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C07HPDRELLD/p1725038167506939

Action Performed | Expected Results | Actual Results:

Case 1: Submit expense (Scan) + Message

Steps:

  1. Submit expense > Scan
  2. Send it to a new account
  3. Send a message right after in the DM

Expected results:

  1. The email is sent right away
  2. The unread summary email contains both the report preview and the message
  3. The report preview shows the receipt scanning state (as the message that follows it triggers it to send right away)

Actual results:

  1. Summary email takes 10 minutes to arrive
  2. ReportPreview is not included in the summary email

2024-08-30_18-00-46
image

Case 3: Message only

Steps

  1. Start chat
  2. Enter the email address of a new account
  3. Send a message in the newly created DM

Expected results:

  1. The unread summary email is sent right away.

Actual results:

  1. The unread summary email is received 10 mins later.
image image

Case 4: Submit expense (Scan) only

Steps:

  1. Submit expense > Scan
  2. Send it to a new account

Expected results:

  1. The email is sent right away after it finishes receipt scanning

Actual results:

  1. Unread summary email never arrives
image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos/Notes

See screenshots above inline.

Note: In the development of this issue, please make sure to test this manual request case which is working correctly right now, as illustrated below.

Case 2: Submit expense (Manual) only

  1. Submit expense > Manual
  2. Send it to a new account
  3. Observe the email is sent upon creation
  4. Observe the unread summary email contains the report preview
image

2024-08-30_17-46-18

View all open jobs on GitHub

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    Hot PickReady for an engineer to pick up and run with
    on Sep 6, 2024
  2. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. trjExpensify commented on Sep 6, 2024

    @trjExpensify
    ContributorAuthor

    Tagging a few peeps that I think have worked on the flows before for vis and volunteering if you can! CC: @marcaaron @blimpich @thienlnam

  4. marcaaron commented on Sep 6, 2024

    @marcaaron
    Contributor

    I'd recommend we remove the case that's working as "expected" from this issue.

    And break it up into 3 issues. Seems there are 3 different problems to solve and think we can parallelize this.

  5. trjExpensify commented on Sep 9, 2024

    @trjExpensify
    ContributorAuthor

    I'd recommend we remove the case that's working as "expected" from this issue.

    We could do that, but I wanted to ensure it's included and considered when testing the proposals/solutions to the other cases. I suspect the lack of considering all of these cases together is what has resulted in inconsistent results and regressions in places.

    And break it up into 3 issues. Seems there are 3 different problems to solve and think we can parallelize this.

    Mhm, maybe.. I think Case 1 and Case 4 are probably the same RCA with a scanned expense receipt. Case 3 is probably a different RCA, as it's a regression to the first message on chat creation not triggering the email to be sent right away anymore.

    I'm a bit hesitant to split these up and have multiple people looking into overlapping (and potentially competing) changes to what is one system for delivering these emails, but I don't mind converting this into more of a tracking issue and have PRs come for whatever parts make sense to break up or something. I think we just need the one volunteer to work through these cases, personally.

  6. melvin-bot commented on Sep 9, 2024

    @melvin-bot

    @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. marcaaron commented on Sep 9, 2024

    @marcaaron
    Contributor

    We could do that, but I wanted to ensure it's included and considered when testing the proposals/solutions to the other cases. I suspect the lack of considering all of these cases together is what has resulted in inconsistent results and regressions in places.

    Can we write a QA regression test for it? It's just a bit confusing what this ticket is asking for. Not trying to criticize here. Mainly trying to think of how to make more actionable and clear tickets that people can grab and go with.

  8. blimpich commented on Sep 9, 2024

    @blimpich
    Contributor

    For case 1 & 3, I believe the summary email not being sent immediately is the expected behavior? My understanding is that we don't want to send those right away since we don't want to flood users with notifications.

    Or are we saying that since they are brand new users we should be sending the notification immediately since we know they likely aren't going to have the app downloaded yet? If so I think that is a new feature, not a bug, and should probably be its own issue.

  9. 39 remaining items

  10. removed their assignment
    on Oct 9, 2024
  11. jasperhuangg commented on Oct 9, 2024

    @jasperhuangg
    Contributor

    My hands are full working on the NewDot SAML Config project, and since this is becoming a fully-fledge project now with a design doc I needa to hand off the project to another engineer to avoid overloading myself.

  12. self-assigned this
    on Oct 10, 2024
  13. jasperhuangg commented on Oct 10, 2024

    @jasperhuangg
    Contributor

    Hoppin back on the team here given DB's post about stopping all #expense priorities and prioritizing #convert

  14. jasperhuangg commented on Oct 10, 2024

    @jasperhuangg
    Contributor

    @trjExpensify Do we want to close out this issue now in favor of the tracking issue?

  15. trjExpensify commented on Oct 10, 2024

    @trjExpensify
    ContributorAuthor

    yep!

  16. m-natarajan commented on Aug 21, 2026

    @m-natarajan

    The following test case is failing on both Android and iOS due to this issue.
    Top DOWN - New user (manager) receives notification and can create new account

  17. mountiny commented on Sep 8, 2026

    @mountiny
    Contributor

    Seems like QA still noted this is happening #100479 (comment), but based on the history, it has been like that for a while. @trjExpensify should we update the test steps?

  18. trjExpensify commented on Sep 8, 2026

    @trjExpensify
    ContributorAuthor

    Which case exactly is failing?

  19. mountiny commented on Sep 10, 2026

    @mountiny
    Contributor

    @izarutskaya @m-natarajan are you able to help here?

  20. m-natarajan commented on Sep 11, 2026

    @m-natarajan

    @trjExpensify @mountiny Will followup and update

  21. m-natarajan commented on Sep 13, 2026

    @m-natarajan
  22. trjExpensify commented on Sep 16, 2026

    @trjExpensify
    ContributorAuthor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions