Skip to content

[HOLD for payment 2024-10-30] [$250] 2nd-level+ Non-admin approver should NOT be able to Submit draft reports on behalf of their submitters #48778

New issue
New issue
Closed
Closed
[HOLD for payment 2024-10-30] [$250] 2nd-level+ Non-admin approver should NOT be able to Submit draft reports on behalf of their submitters#48778
Assignees
Beamanatorgreg-schroederikevin127cretadn22
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@garrettmknight
garrettmknight
opened on Sep 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: logs-2024-09-13 16_55_08.340.txt
Expensify/Expensify Issue URL:
Issue reported by: @saracouto
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1725864497268339

Action Performed:

  1. Create a workspace
  2. Invite a submitter and 2 approvers (both NON-ADMINS)
  3. Enable approvals setting Submitter -> submitsTo approver 1 -> forwardsTo approver 2
  4. Enable Delay submissions
  5. Create an expense as the submitter
  6. As the approver 1, submit & approve the report
  7. As the approver 2, navigate to the submitter's workspace chat

Expected Result:

As a second-level+ non-admin approver, you should NOT see the 'submit' button.

Actual Result:

As a non-admin approver, you see the 'submit' button. When you tap/click it, you get an error.

Workaround:

There is no workaround.

Platforms:

All

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833163296746944359
  • Upwork Job ID: 1833163296746944359
  • Last Price Increase: 2024-10-10
  • Automatic offers:
    • ikevin127 | Reviewer | 104458910
    • cretadn22 | Contributor | 104458913
Issue OwnerCurrent Issue Owner: @greg-schroeder

Activity

  1. garrettmknight
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 9, 2024
  2. garrettmknight
    added this to #expensify-bugson Sep 9, 2024
  3. garrettmknight
    moved this to Hot Picks in #expensify-bugson Sep 9, 2024
  4. melvin-bot
    assigned
    greg-schroeder
    on Sep 9, 2024

  5. melvin-bot commented on Sep 9, 2024

    @melvin-bot
    melvin-botBot
    on Sep 9, 2024 – with Melvin Bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. NJ-2020 commented on Sep 9, 2024

    @NJ-2020
    NJ-2020
    on Sep 9, 2024 · Hidden as outdated

  7. ChavdaSachin commented on Sep 9, 2024

    @ChavdaSachin
    ChavdaSachin
    on Sep 9, 2024 · Hidden as outdated

  8. nyomanjyotisa commented on Sep 9, 2024

    @nyomanjyotisa
    nyomanjyotisa
    on Sep 9, 2024 · Hidden as outdated
  9. Beamanator
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 9, 2024
  10. melvin-bot
    changed the title [-]Non-admin approver shouldn't see the Submit option for submitters[/-] [+][$250] Non-admin approver shouldn't see the Submit option for submitters[/+] on Sep 9, 2024

  11. melvin-bot commented on Sep 9, 2024

    @melvin-bot
    melvin-botBot
    on Sep 9, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021833163296746944359

  12. Beamanator
    self-assigned this
    on Sep 9, 2024
  13. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 9, 2024
  14. melvin-bot
    assigned
    ikevin127
    on Sep 9, 2024

  15. 116 remaining items

  16. melvin-bot
    removed
    ReviewingHas a PR in review
    on Oct 23, 2024

  17. melvin-bot commented on Oct 23, 2024

    @melvin-bot
    melvin-botBot
    on Oct 23, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Oct 23, 2024

    @melvin-bot
    melvin-botBot
    on Oct 23, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-30. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Oct 23, 2024

    @melvin-bot
    melvin-botBot
    on Oct 23, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  20. ikevin127 commented on Oct 28, 2024

    @ikevin127
    ikevin127
    on Oct 28, 2024
    Contributor
    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: N/A.

    Wasn't able to pinpoint to a specific PR to have caused this because the shouldShowSubmitButton variable simply did not include the logic for our issue's case which was detailed in selected proposal.

    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A.
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Create a workspace.
    2. Invite a submitter and 2 approvers (both NON-ADMINS).
    3. Enable approvals setting Submitter -> submitsTo approver 1 -> forwardsTo approver 2.
    4. Enable Delay submissions.
    5. Create an expense as the submitter.
    6. As the approver 1, submit and approve the report.
    7. As the approver 2, navigate to the submitter's workspace chat.
    8. See that the second-level (non-admin) approver should NOT see the Submit button.

    Do we agree 👍 or 👎.

  21. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 29, 2024

  22. ikevin127 commented on Oct 31, 2024

    @ikevin127
    ikevin127
    on Oct 31, 2024
    Contributor

    cc @greg-schroeder

  23. melvin-bot
    added
    Overdue
    on Oct 31, 2024

  24. greg-schroeder commented on Nov 1, 2024

    @greg-schroeder
    greg-schroeder
    on Nov 1, 2024
    Contributor

    Processing

  25. melvin-bot
    removed
    Overdue
    on Nov 1, 2024
  26. greg-schroeder
    closed this as completedon Nov 1, 2024

  27. melvin-bot commented on Nov 1, 2024

    @melvin-bot
    melvin-botBot
    on Nov 1, 2024 – with Melvin Bot

    @Beamanator @greg-schroeder Be sure to fill out the Contact List!

  28. github-project-automation
    moved this from Polish to Done in #expensify-bugson Nov 1, 2024

  29. greg-schroeder commented on Nov 1, 2024

    @greg-schroeder
    greg-schroeder
    on Nov 1, 2024
    Contributor

    Payment summary:

    Contributor: @cretadn22 - $250 - Paid via Upwork
    C+: @ikevin127 - $250 - Paid via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions