Repository navigation
[$250] Android & iOS - #announce room title is left aligned in room details page #48964
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Launch New Expensify app.
- Go to #announce room.
- Tap on the room header.
Expected Result:
#announce room title will be centered.
Actual Result:
#announce room title is left aligned, while the workspace name below it is centered.
The same issue also happens in thread.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6599469_1726021836352.d.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021833780466930093925
- Upwork Job ID: 1833780466930093925
- Last Price Increase: 2024-09-11
Activity
melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Sep 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Sep 11, 2024
Prod
melvin-bot commentedon Sep 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021833780466930093925
[-]Android & iOS - #announce room title is left aligned in room details page[/-][+][$250] Android & iOS - #announce room title is left aligned in room details page[/+]10 remaining items
Guccio163 commentedon Sep 11, 2024
I believe that
flex: 1isn't a problem per se, just thattitleStylewasn't directly centered previously since whole shrunken Text component was. In my opinion we should addtextAlign: 'center'directly totextStylesboth innameSectionGroupWorkspace(line 631) andnameSectionTitleField(line 678) like that:titleStyle={{textAlign: 'center', ...styles.newKansasLarge}}Like @rayane-djouah just stated this comes directly from the PR that we were working on, moreover I'm Wiktor Gut from SWM agency so I can fix it for you right away. If you agree with me, please assign me this issue.
allgandalf commentedon Sep 11, 2024
removing my assignment as per slack
melvin-bot commentedon Sep 11, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Guccio163 commentedon Sep 11, 2024
PR above solves this issue once it's merged, because it reverts previous interference on
MenuItemand hence this section, result is right:Guccio163 commentedon Sep 11, 2024
PR is merged, this issue can be closed
luacmartins commentedon Sep 11, 2024
The CP is still ongoing. I'll verify the fix in staging and then close the issue
luacmartins commentedon Sep 11, 2024
This is fixed on staging. Closing.