Repository navigation
[HOLD for payment 2024-10-04] [$250] [Workspace Feeds] There's no checkmark next to the current settlement account being used. #48974
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.31-24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725977031984379
Action Performed:
- Enable the Expensify Card
- Click
Settingsat the top of the Expensify Card page - Click
Settlement account
Expected Result:
The bank account being used should be highlighted with a checkmark
Actual Result:
There's no checkmark against the bank account being used for settlements.
Note: We also want to make sure we refactor the Wallet > Transfer Balance screen to use this same select list styling, as right now it has radio buttons, so let's make it consistent:
Workaround:
N/A, visual design bug.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
See above in-line.
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021836004132424001151
- Upwork Job ID: 1836004132424001151
- Last Price Increase: 2024-09-17
Activity
melvin-bot commentedon Sep 11, 2024
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
trjExpensify commentedon Sep 11, 2024
Someone on the Workspace Feeds team will take this, looking for who's available.
koko57 commentedon Sep 11, 2024
I can work on this issue
trjExpensify commentedon Sep 11, 2024
Thanks!
koko57 commentedon Sep 11, 2024
With the non-checked bank account problem - same root cause as in #48943 (comment) - we don't have bankAccountID in the accountData object - after
OpenPaymentsPagewe have this data so the bank account is properly checked.We have methodID instead, so I will check for both bankAccountID and methodID.
@trjExpensify just to make sure: we're talking of changing the Wallet > Transfer Balance page to use the same design as Settlement Account page (not the way around?) - list items instead of radio buttons?
52 remaining items
trjExpensify commentedon Oct 4, 2024
Offers sent!
melvin-bot commentedon Oct 4, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
allgandalf commentedon Oct 4, 2024
Accepted thanks :)
trjExpensify commentedon Oct 4, 2024
@allgandalf paid!
allgandalf commentedon Oct 4, 2024
HEROOOO! ❤️ 🦸
Update: @trjExpensify I guess i was not paid and the contract was closed, can you take a look please :))
trjExpensify commentedon Oct 4, 2024
Something is fucked with Upwork. That's the second time in a matter of hours. (CC: @ikevin127).
I made the payment and closed the contract:
Can we give this until Monday to see if Upwork is on the blink and then I'll do a fresh one if not?
allgandalf commentedon Oct 4, 2024
Yeah cool, I though my upwork fucked up for a bit 😅 , have a great weekend!
trjExpensify commentedon Oct 4, 2024
Who knows, but yeah.. let's give them a bit to sort it out and then if it doesn't come through, I'll do a new contract.
trjExpensify commentedon Oct 7, 2024
Alright, @DylanDylann has accepted the offer I sent on Friday. I'm going to try and end that now and see if Upwork has resolved itself. Then I'll send another to @allgandalf.
trjExpensify commentedon Oct 8, 2024
Paid @allgandalf a bonus on the original borked contract to skirt the Upwork bug. Closing!