[OldDot Rules Migration] [Polish] [$250] Editing Approver offline does not gray out category but grays out Approver for other categories

@eh2077

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.32-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4948337
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

Rules are enabled.

Go to staging.new.expensify.com
Go to workspace settings > Categories.
Go offline.
Click on any category.
Click Approver.
Add any approver.
Close the RHP.
Note that the edited category is not grayed out.
Open a different category.
Note that Approver field is grayed out when it is not edited.

Expected Result:

In Step 8. the edited category should be grayed out after modifying Approver field offline.
In Step 10, the Approver field for other categories should not gray out when the categories are untouched.

Actual Result:

In Step 8. the edited category is not grayed out after modifying Approver field offline.
In Step 10, the Approver field for other categories is gray out when the categories are untouched.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6600099_1726068970972.bandicam_2024-09-11_23-29-56-435.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833957180531669064
Upwork Job ID: 1833957180531669064
Last Price Increase: 2024-09-11

Issue Owner

Current Issue Owner: @eh2077

@luacmartins

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@dylanexpensify

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@WojtekBoman

Might be related to #48171. cc @WojtekBoman @dukenv0307 @marcaaron

Edited by proposal-police: This proposal was edited at 2024-09-11 18:47:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8. the edited category is not grayed out after modifying Approver field offline.
In Step 10, the Approver field for other categories is gray out when the categories are untouched.

What is the root cause of that problem?

We have 2 bugs in here

The edited category is not grayed out after modifying Approver field offline.

In here we show grayed out when we have pending action of policy category and we not update it when set policy category approver

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 279 in 1e8e4f4

    
           const hasVisibleCategories = categoryList.some((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline);

The Approver field for other categories is gray out when the categories are untouched.

In here we show grayed out when we have pending fields approvalRules and use this variable for all category when set policy category approver

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 260 in 1e8e4f4

    
           <OfflineWithFeedback pendingAction={policy?.rules?.pendingFields?.approvalRules}>

What changes do you think we should make in order to solve the problem?

The edited category is not grayed out after modifying Approver field offline.

We should update pending action of policy category in optimisticData when we set policy category approver here

    {
          onyxMethod: Onyx.METHOD.MERGE,
          key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
          value: {
              [categoryName]: {
                  pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
              }
          }
      }

And we can do the same with all fields in category setting.

The Approver field for other categories is grayed out when the categories are untouched.

We should update the format pendingFields of approvalRules here like

 pendingFields: {
      [categoryName]: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
  },

do the same with failureDate and successData

And update pendingAction here to show grayed out with each value of category name

pendingAction={policy?.rules?.pendingFields?.[categoryName]}

What alternative solutions did you explore? (Optional)

@nkdengineer

@nkdengineer is this a regression from a recent PR?

I'm gonna demote this from being a blocker since it's a minor issue.

Hi! I can fix that as I'm the author of the PR that caused this regression

Nice! Merged

@eh2077

Payment summary:

Contributor+: @eh2077 $250 via NewDot

Please apply/request!

Requested in NewDot

@eh2077

$250 approved for @eh2077

Navigation Menu

Repository navigation

[OldDot Rules Migration] [Polish] [$250] Editing Approver offline does not gray out category but grays out Approver for other categories #49009

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

12 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[OldDot Rules Migration] [Polish] [$250] Editing Approver offline does not gray out category but grays out Approver for other categories #49009

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 11, 2024

melvin-bot commented on Sep 11, 2024

github-actions commented on Sep 11, 2024

luacmartins commented on Sep 11, 2024

nkdengineer commented on Sep 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

luacmartins commented on Sep 11, 2024

luacmartins commented on Sep 11, 2024

12 remaining items

WojtekBoman commented on Sep 12, 2024

dylanexpensify commented on Sep 18, 2024

dylanexpensify commented on Oct 7, 2024

eh2077 commented on Oct 10, 2024

JmillsExpensify commented on Oct 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions