Skip to content

[HOLD for Payment 2024-09-25] [Search v2.1][$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP  #49080

New issue
New issue
Closed
Closed
[HOLD for Payment 2024-09-25] [Search v2.1][$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP #49080
Assignees
trjExpensifyluacmartinsbernhardojikevin127
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@m-natarajan
m-natarajan
opened on Sep 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726117464938269

Action Performed:

  1. Go to the search page
  2. Click Enter
  3. Observe the workspace switcher opens
  4. Click out of the workspace switcher
  5. Click Chats
  6. Click Expenses
  7. Click Outstanding
  8. Click Enter
  9. Observe the RHP opens.

Expected Result:

The workspace switcher or the RHP does not open when clicking Enter on the search page.

Actual Result:

The workspace switcher and RHP open when clicking Enter

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-09-12.at.02.49.56.mp4

View all open jobs on GitHub

Recording.539.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834395341977846523
  • Upwork Job ID: 1834395341977846523
  • Last Price Increase: 2024-09-13
  • Automatic offers:
    • ikevin127 | Reviewer | 103975534
Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. m-natarajan
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 12, 2024
  2. melvin-bot
    assigned
    trjExpensify
    on Sep 12, 2024

  3. melvin-bot commented on Sep 12, 2024

    @melvin-bot
    melvin-botBot
    on Sep 12, 2024 – with Melvin Bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. suneox commented on Sep 12, 2024

    @suneox
    suneox
    on Sep 12, 2024
    Contributor

    I think the expected behavior at step 6 is that the report detail page should not be shown, due to the lack of context to select which expense from the list.

  5. trjExpensify commented on Sep 13, 2024

    @trjExpensify
    trjExpensify
    on Sep 13, 2024
    Contributor

    Hm, I'm not sure about this actually. Why would we open anything at all when Enter is clicked? We don't do that on other pages. @luacmartins am I missing something on why the Enter key is opening the workspace switcher here?

  6. trjExpensify
    added this to #expensify-bugson Sep 13, 2024
  7. trjExpensify
    moved this to Polish in #expensify-bugson Sep 13, 2024

  8. luacmartins commented on Sep 13, 2024

    @luacmartins
    luacmartins
    on Sep 13, 2024
    Contributor

    My best guess is that we have focus trap on some button and we're triggering that onPress behavior when pressing enter

  9. trjExpensify
    changed the title [-]The behavior of the “Enter” key is inconsistent on the search expenses screen.[/-] [+]The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/+] on Sep 13, 2024

  10. trjExpensify commented on Sep 13, 2024

    @trjExpensify
    trjExpensify
    on Sep 13, 2024
    Contributor

    Yeah, so I think the expected behaviour here is that the workspace switcher nor the expense RHP opens when you randomly click Enter on the search page.

  11. trjExpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 13, 2024
  12. melvin-bot
    changed the title [-]The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/-] [+][$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/+] on Sep 13, 2024

  13. melvin-bot commented on Sep 13, 2024

    @melvin-bot
    melvin-botBot
    on Sep 13, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021834395341977846523

  14. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 13, 2024

  15. 10 remaining items

  16. melvin-bot commented on Sep 15, 2024

    @melvin-bot
    melvin-botBot
    on Sep 15, 2024 – with Melvin Bot

    📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  17. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Sep 16, 2024

  18. bernhardoj commented on Sep 16, 2024

    @bernhardoj
    bernhardoj
    on Sep 16, 2024
    Contributor

    PR is ready

    cc: @ikevin127

  19. ikevin127 commented on Sep 18, 2024

    @ikevin127
    ikevin127
    on Sep 18, 2024
    Contributor

    ⚠️ Automation failed here -> this should be on [HOLD for Payment 2024-09-25] according to today's production deploy from Deploy Checklist: New Expensify 2024-09-17 which was shipped to production today.

    cc @trjExpensify

  20. trjExpensify
    changed the title [-][$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/-] [+][HOLD for Payment 2024-09-25] [$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/+] on Sep 18, 2024
  21. trjExpensify
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Sep 18, 2024

  22. trjExpensify commented on Sep 18, 2024

    @trjExpensify
    trjExpensify
    on Sep 18, 2024
    Contributor

    Thanks!

  23. luacmartins
    changed the title [-][HOLD for Payment 2024-09-25] [$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/-] [+][HOLD for Payment 2024-09-25] [Search v2.1][$250] The “Enter” key on the search page randomly opens the workspace switcher or the RHP [/+] on Sep 19, 2024

  24. trjExpensify commented on Sep 25, 2024

    @trjExpensify
    trjExpensify
    on Sep 25, 2024
    Contributor

    Payment summary as follows:

    Closing!

  25. trjExpensify
    closed this as completedon Sep 25, 2024

  26. bernhardoj commented on Sep 25, 2024

    @bernhardoj
    bernhardoj
    on Sep 25, 2024
    Contributor

    Requested in ND.

  27. JmillsExpensify commented on Sep 25, 2024

    @JmillsExpensify
    JmillsExpensify
    on Sep 25, 2024
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions