Repository navigation
[$250] [Performance] Persist image scans when clearing cache and restarting [Payment is due on OCT 8] #49085
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
When multiple requests fail and jam up the sequential queue for several minutes (which is being investigated and fixed) the fastest way to GSD again is to use Clear cache and restart in the Troubleshoot menu.
The byproduct of doing this is that if you have any messages or receipt uploads waiting for their request to process, they are lost when you hit that button.
What is the impact of this on end-users?
Users lose their receipt images.
List any benchmarks that show the severity of the issue
Please also provide exact steps taken to collect metrics above if any so we can independently verify the results.
N/A
Proposed solution (if any)
Please list out the steps you think we should take to solve this issue.
Ask the end user for permission to store all pending receipt uploads to their phone's camera roll, add the receipts to the camera roll, and automatically add them to the camera roll next time.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Note: These should be the same as the benchmarks collected before any changes.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1726082473000159?thread_ts=1726059136.088489&cid=C05LX9D6E07
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021834242849711510101
- Upwork Job ID: 1834242849711510101
- Last Price Increase: 2024-09-12
Issue Owner
Current Issue Owner: @mananjadhavMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Sep 12, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
melvin-bot commentedon Sep 12, 2024
Triggered auto assignment to @isabelastisser (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.melvin-bot commentedon Sep 12, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 12, 2024
melvin-bot commentedon Sep 12, 2024
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)25 remaining items
TMisiukiewicz commentedon Sep 23, 2024
opened #49588 👍
melvin-bot commentedon Sep 24, 2024
Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
isabelastisser commentedon Sep 30, 2024
@mananjadhav @TMisiukiewicz It looks like the PR was deployed 3 days ago and no payment for an external contributor is needed. Do we need a regression test? Should this be closed?
mananjadhav commentedon Sep 30, 2024
@isabelastisser There would be a payout for me. I helped review the PR. We'll need to wait through the regression period.
isabelastisser commentedon Sep 30, 2024
Thanks for the update!
[-][$250] [Performance] Request permission and store cached receipts in camera roll when using clear cache and restart[/-][+][$250] [Performance] Persist image scans when clearing cache and restarting [/+]mananjadhav commentedon Oct 1, 2024
This was deployed yesterday so the payout should be 10/8.
[-][$250] [Performance] Persist image scans when clearing cache and restarting [/-][+][$250] [Performance] Persist image scans when clearing cache and restarting [Payment is due on OCT 8][/+]mananjadhav commentedon Oct 8, 2024
@isabelastisser This is ready for payout. I don't have any offending PR for this one. Neither any regression test. This was more of a performance change.
isabelastisser commentedon Oct 8, 2024
Payment summary:
$250 to @mananjadhav for C+ review - Payment pending in Upwork.
garrettmknight commentedon Oct 15, 2024
$250 approved for @mananjadhav
@isabelastisser payment for him is in ND.