Skip to content

[HOLD for Payment 2024-10-08][$250] [Search v2.2] - Report name is bold when report is unread or select, and unbold when not unselected #49100

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.33-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search > Chats.
  3. Click Filters.
  4. Click In.
  5. Select some reports.

Expected Result:

There should be consistency whether the report name should be bold.

Actual Result:

The report name is bold when the report is unread or selected, and unbold when not selected.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6601202_1726156396378.bandicam_2024-09-12_23-50-21-440.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834272973003292308
  • Upwork Job ID: 1834272973003292308
  • Last Price Increase: 2024-09-12
  • Automatic offers:
    • ikevin127 | Reviewer | 104115265
Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 12, 2024
  2. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Sep 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 12, 2024
  6. 58 remaining items

  7. melvin-bot commented on Sep 26, 2024

    @melvin-bot

    @OfstadC @luacmartins @bernhardoj @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  8. trjExpensify commented on Sep 26, 2024

    @trjExpensify
    Contributor

    Right, we need to consider an appropriate sub-line for each report type returned in the results of the `In: filter, but I think that's fine, and suggest something that communicates the data type a bit. So for the missing ones, that would be the below I think:

    taskName
    Task

    expense report/IOU report/transaction thread report name
    Expense

    threadName (for "normal" message threads)
    Thread

    groupName
    Group

    CC: @JmillsExpensify

  9. bernhardoj commented on Sep 27, 2024

    @bernhardoj
    Contributor

    Thanks! PR is ready

    cc: @ikevin127

  10. ikevin127 commented on Sep 30, 2024

    @ikevin127
    Contributor

    ♻️ Status update: The PR was deployed to staging (#49835 (comment)).

  11. ikevin127 commented on Oct 2, 2024

    @ikevin127
    Contributor

    ⚠️ Automation failed here -> this should be on [HOLD for Payment 2024-10-08] according to yesterday’s production deploy from #49835 (comment).

    cc @OfstadC

  12. changed the title [-][$250] [Search v2.2] - Report name is bold when report is unread or select, and unbold when not unselected[/-] [+][HOLD for Payment 2024-10-08][$250] [Search v2.2] - Report name is bold when report is unread or select, and unbold when not unselected[/+] on Oct 3, 2024
  13. OfstadC commented on Oct 8, 2024

    @OfstadC
    Contributor

    Payment Summary

  14. bernhardoj commented on Oct 8, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  15. JmillsExpensify commented on Oct 15, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions