[HOLD for payment 2024-10-10] [$250] Bank Account - "Please provide a valid email" error is not dismissed when navigating back

@anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): gibethlehem.@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Log in to an account
Create a workspace > Enable Workflow > Connect bank account > Connect online with plaid
continues the flow until you reached "Company website" page
Click on "Next" button with out entering an email. Notice error is shown.
Navigate back to "Tax" > Click next. Notice "Please provide a valid email" is shown
Navigate back

Expected Result:

"Please provide a valid email" error is not shown

Actual Result:

"Please provide a valid email" error is shown even after navigating back to other pages.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6601153_1726153889912.12.09.2024_17.40.24_REC.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021838748303382636901
Upwork Job ID: 1838748303382636901
Last Price Increase: 2024-09-25
Automatic offers:

allgandalf | Reviewer | 104202965

Issue Owner

Current Issue Owner: @anmurali

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@anmurali

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-09-12 19:20:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The OP is incorrect. Should be Please provide a valid website error.

"Please provide a valid website" error is shown even after navigating back to other pages.

What is the root cause of that problem?

Offending PR: #48731

We save the defaultCompanyWebsite here as draft:

App/src/pages/ReimbursementAccount/BusinessInfo/substeps/WebsiteBusiness.tsx

Lines 62 to 64 in 2310966

    
           useEffect(() => { 
        
               BankAccounts.addBusinessWebsiteForDraft(defaultCompanyWebsite); 
        
           }, [defaultCompanyWebsite]);

But the default value might either be a website prefix placeholder https:// or a public domain website:

App/src/libs/BankAccountUtils.ts

Lines 5 to 7 in 6c5125d

    
           function getDefaultCompanyWebsite(session: OnyxEntry<OnyxTypes.Session>, user: OnyxEntry<OnyxTypes.User>): string { 
        
               return user?.isFromPublicDomain ? 'https://' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`; 
        
           }

If https:// is saved to the form draft, we would call the UpdateCompanyInformationForBankAccount with website: "https://" attribute and the BE would return the Please provide a valid Website error which keeps showing in all the sub-steps because it is a form error.

What changes do you think we should make in order to solve the problem?

https:// should not be saved as draft because it's just an input placeholder value.

We should early return in the above effects if defaultCompanyWebsite === 'https://'.

@anmurali

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

@anmurali

@anmurali Can you check this?

@anmurali

@anmurali Eep! 4 days overdue now. Issues have feelings too...

@anmurali

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@anmurali

@anmurali 10 days overdue. I'm getting more depressed than Marvin.

Job added to Upwork: https://www.upwork.com/jobs/~021838748303382636901

@mallenexpensify

Apologies for the delay @twilight294 , can you please apply for the job, then we'll hire and pay?
https://www.upwork.com/jobs/~021844895880907146867

Sorry, I don't have enough connects on upwork to apply, is there a way to hire me directly @mallenexpensify ?
my upwork is: https://www.upwork.com/freelancers/~01047e1bc60ea55d80

@mallenexpensify

hello @mallenexpensify , reminder since it was weekend last time i texted ^

@anmurali

@anmurali, @blimpich, @allgandalf, @twilight294 Huh... This is 4 days overdue. Who can take care of this?

Not overdue sir melvin! 🙇

@mallenexpensify

hello @mallenexpensify , can you please help me out with #49129 (comment)

Apologies @twilight294 , I just invited you to the job, can you accept then I'll pay?
In the 3+ years we've been working with Upwork, I haven't encountered the issue you're experiencing.

@mallenexpensify

Thanks for the invite @mallenexpensify , I don't know what is happening, but upwork never allocated me connects :

I think it's hard for newer freelancers in Upwork. And, for working with us, once you've been hired for 1 job it's a LOT easier to find and hire you for future jobs. Can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021844895880907146867

I accepted the offer, thank you so much, Looking forward to working on more issues

Thanks @twilight294 , you've been paid. Payment breakdown updated above too.

Test case created too

https://github.com/Expensify/Expensify/issues/436636

🚀

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-10] [$250] Bank Account - "Please provide a valid email" error is not dismissed when navigating back #49129

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

41 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	BankAccounts.addBusinessWebsiteForDraft(defaultCompanyWebsite);
	}, [defaultCompanyWebsite]);

	function getDefaultCompanyWebsite(session: OnyxEntry<OnyxTypes.Session>, user: OnyxEntry<OnyxTypes.User>): string {
	return user?.isFromPublicDomain ? 'https://' : `https://www.${Str.extractEmailDomain(session?.email ?? '')}`;
	}

[HOLD for payment 2024-10-10] [$250] Bank Account - "Please provide a valid email" error is not dismissed when navigating back #49129

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 12, 2024

IuliiaHerets commented on Sep 12, 2024

gijoe0295 commented on Sep 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Sep 16, 2024

gijoe0295 commented on Sep 17, 2024

melvin-bot commented on Sep 18, 2024

melvin-bot commented on Sep 20, 2024

melvin-bot commented on Sep 24, 2024

melvin-bot commented on Sep 25, 2024

41 remaining items

twilight2294 commented on Oct 12, 2024

twilight2294 commented on Oct 14, 2024

melvin-bot commented on Oct 14, 2024

allgandalf commented on Oct 14, 2024

twilight2294 commented on Oct 15, 2024

mallenexpensify commented on Oct 16, 2024

twilight2294 commented on Oct 16, 2024

mallenexpensify commented on Oct 16, 2024

twilight2294 commented on Oct 16, 2024

mallenexpensify commented on Oct 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions