You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-09-27][Search v2.3] - Same saved search can be created at most twice #49205
Version Number: 9.0.35-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers):applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Search.
Click Filters.
Select Merchant and add search query (issue is reproducible with Merchant filter and not Date, Total filter).
Click Save search.
Click 3-dot menu next to the saved search > Rename.
Enter a custom name and save it.
Click Filters > Save search.
Note that it creates another saved search.
Rename the second saved search.
Go back to the first saved search.
Click Filters > Save search.
Note that it does not create a new search but changes the name of second saved search back to default.
Expected Result:
In Step 9, it will not create another same saved search because the filters are not modified.
Actual Result:
In Step 9, it creates another same saved search when the filters are not modified.
If Step 9 is the correct behavior, Step 13 shows a different result because user cannot create the same third saved from the first saved search as it changes the name of second saved search back to default.
This issue is not reproducible when Date and Total filter are used.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is coming from this PR. Gonna demote it to NAB, since it's not breaking any functionality. @lakchote we need to figure out why the hashes are different in this case.
Activity
melvin-bot commentedon Sep 14, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 14, 2024
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
luacmartins commentedon Sep 15, 2024
This is coming from this PR. Gonna demote it to NAB, since it's not breaking any functionality. @lakchote we need to figure out why the hashes are different in this case.
12 remaining items
lakchote commentedon Sep 24, 2024
Not overdue. Awaiting payment.
OfstadC commentedon Sep 27, 2024
Payment Summary
melvin-bot commentedon Sep 27, 2024
Payment Summary
Upwork Job
BugZero Checklist (@OfstadC)
JmillsExpensify commentedon Oct 14, 2024
$250 approved for @allroundexperts