Skip to content

[HOLD for payment 2024-09-27][Search v2.3] - Same saved search can be created at most twice #49205

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Click Filters.
  4. Select Merchant and add search query (issue is reproducible with Merchant filter and not Date, Total filter).
  5. Click Save search.
  6. Click 3-dot menu next to the saved search > Rename.
  7. Enter a custom name and save it.
  8. Click Filters > Save search.
  9. Note that it creates another saved search.
  10. Rename the second saved search.
  11. Go back to the first saved search.
  12. Click Filters > Save search.
  13. Note that it does not create a new search but changes the name of second saved search back to default.

Expected Result:

In Step 9, it will not create another same saved search because the filters are not modified.

Actual Result:

In Step 9, it creates another same saved search when the filters are not modified.

If Step 9 is the correct behavior, Step 13 shows a different result because user cannot create the same third saved from the first saved search as it changes the name of second saved search back to default.

This issue is not reproducible when Date and Total filter are used.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6603096_1726280498834.20240914_101401.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 14, 2024
  2. melvin-bot commented on Sep 14, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 14, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Sep 14, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. luacmartins commented on Sep 15, 2024

    @luacmartins
    Contributor

    This is coming from this PR. Gonna demote it to NAB, since it's not breaking any functionality. @lakchote we need to figure out why the hashes are different in this case.

  6. 12 remaining items

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 23, 2024
  8. lakchote commented on Sep 24, 2024

    @lakchote
    Contributor

    Not overdue. Awaiting payment.

  9. moved this from Polish to Done in #expensify-bugson Sep 26, 2024
  10. OfstadC commented on Sep 27, 2024

    @OfstadC
    Contributor

    Payment Summary

  11. melvin-bot commented on Sep 27, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@OfstadC)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. JmillsExpensify commented on Oct 14, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions