Repository navigation
[$250] [Search v2.3] - Current name is not populated in the name field and it is not auto-focused #49207
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48566
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- User has saved a few searches.
- Go to staging.new.expensify.com
- Go to Search.
- Click 3-dot menu next to a saved search > Rename.
- Save a custom name.
- Click 3-dot menu next to the same saved search > Rename.
Expected Result:
The current name will be populated in the name field and it will auto-focused.
Actual Result:
The current name is not populated in the name field and it is not auto-focused.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6603105_1726282008408.20240914_104412.mp4
Issue Owner
Current Issue Owner: @jayeshmangwaniUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021836684527709552516
- Upwork Job ID: 1836684527709552516
- Last Price Increase: 2024-09-19
- Automatic offers:
- Nodebrute | Contributor | 104051960
Metadata
Metadata
Labels
Type
Projects
- Status
Activity
github-actions commentedon Sep 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Sep 14, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 14, 2024
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Nodebrute commentedon Sep 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Current name is not populated in the name field and it is not auto-focused
What is the root cause of that problem?
We are not autofocusing this field and we are also not adding defaultValue
What changes do you think we should make in order to solve the problem?
We can add const {inputCallbackRef} = useAutoFocusInput(); and then pass it here
We can also pass
defaultValue={name}Optional: we can also pass
valuepropWhat alternative solutions did you explore? (Optional)
srikarparsi commentedon Sep 14, 2024
Hi @lakchote or @luacmartins, do you think you could take a look at this whenever you have a chance? I think this comes from this PR
srikarparsi commentedon Sep 14, 2024
I think the auto-focussed part has been reported here
luacmartins commentedon Sep 15, 2024
This is known and NAB. We're addressing it in a follow up
23 remaining items
melvin-bot commentedon Sep 20, 2024
📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Nodebrute commentedon Sep 20, 2024
I’ll raise a PR in a few hours.
slafortune commentedon Sep 23, 2024
not deployed yet
melvin-bot commentedon Sep 25, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Nodebrute commentedon Oct 7, 2024
^ False positive my PR didn't cause the issue mentioned in #49739. The change we made was simple, involving autofocus and setting a default value for the field.
The root cause of the other issue was this PR, where we introduced the title variable but forgot to pass it to the navigation function see #49235 (comment)
jayeshmangwani commentedon Oct 8, 2024
@slafortune PR has been in production for 2 weeks, and it's now ready for payment.
slafortune commentedon Oct 9, 2024
@jayeshmangwani - Role C+ - is due $250 via New Dot
@Nodebrute - Role Contributor - Paid $250 via Upworks
jayeshmangwani commentedon Oct 9, 2024
@slafortune Please update the summary, I am not an Expert Contributor; I am a C+.
garrettmknight commentedon Oct 15, 2024
$250 approved for @jayeshmangwani