[Search v2.3] - Saved filter tool tip is hard to read on dark theme

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): nathanmulugetatesting+1482@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition: App theme should be in dark mode.

Navigate to staging.new.expensify.com
Navigate to search
Click on filter
Setup any filter and save it

Expected Result:

The tooltip is easily readable

Actual Result:

The tooltip is hard to read on dark theme

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6603169_1726291858246.bandicam_2024-09-14_08-26-44-191.mp4

View all open jobs on GitHub

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-control

@francoisl

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tooltip is hard to read on dark theme

What is the root cause of that problem?

We're using text color for the tooltip:

App/src/pages/Search/SearchTypeMenu.tsx

Line 145 in 2dc08e9

    
           <Text style={[styles.ml1, styles.textLabel]}>{translate('search.saveSearchTooltipText')}</Text>

App/src/styles/index.ts

Lines 376 to 377 in 14c8409

    
           textLabel: { 
        
               color: theme.text,

What changes do you think we should make in order to solve the problem?

Use quickActionTooltipSubtitle style which contains textDark color:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 206 in ee12dfd

    
           <Text style={styles.quickActionTooltipSubtitle}>{translate('quickAction.tooltip.subtitle')}</Text>

App/src/styles/index.ts

Lines 3910 to 3913 in 14c8409

    
           quickActionTooltipSubtitle: { 
        
               fontSize: variables.fontSizeLabel, 
        
               color: theme.textDark, 
        
           },

@luacmartins

offending PR #48566, cc @luacmartins @lakchote

PR here

Fixed in staging

Navigation Menu

Repository navigation

[Search v2.3] - Saved filter tool tip is hard to read on dark theme #49213

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	quickActionTooltipSubtitle: {
	fontSize: variables.fontSizeLabel,
	color: theme.textDark,
	},

[Search v2.3] - Saved filter tool tip is hard to read on dark theme #49213

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 14, 2024

IuliiaHerets commented on Sep 14, 2024

melvin-bot commented on Sep 14, 2024

github-actions commented on Sep 14, 2024

gijoe0295 commented on Sep 14, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

ishpaul777 commented on Sep 14, 2024

luacmartins commented on Sep 15, 2024

luacmartins commented on Sep 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions