Skip to content

[$250] [HOLD for payment 2024-09-23] [Search v2.3] - App crashes after saving search with user and clear cache and restart #49249

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.35-4
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+dfjdfer@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search > Chats.
  3. Click Filters.
  4. Click From.
  5. Select any user.
  6. Click Save search.
  7. Go to Account settings > Troubleshoot > Clear cache and restart.
  8. Click Reset and refresh.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1609.txt

Bug6605199_1726476130689.20240916_163618.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838824379471456613
  • Upwork Job ID: 1838824379471456613
  • Last Price Increase: 2024-09-25
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 16, 2024
  2. melvin-bot commented on Sep 16, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Sep 16, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Sep 16, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. IuliiaHerets commented on Sep 16, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-control

  6. nkdengineer commented on Sep 16, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App crashes.

    What is the root cause of that problem?

    personalDetails is undefined after we reset cache and restart.

    return PersonalDetailsUtils.createDisplayName(personalDetails[filter]?.login ?? '', personalDetails[filter]);

    What changes do you think we should make in order to solve the problem?

    Safely get the data here

    return PersonalDetailsUtils.createDisplayName(personalDetails?.[filter]?.login ?? '', personalDetails?.[filter]);
    
    

    return PersonalDetailsUtils.createDisplayName(personalDetails[filter]?.login ?? '', personalDetails[filter]);

    Or we can set the default value of personalDetails as empty object.

    What alternative solutions did you explore? (Optional)

  7. techievivek commented on Sep 16, 2024

    @techievivek
    Contributor

    It might be related to this PR #48566

  8. techievivek commented on Sep 16, 2024

    @techievivek
    Contributor

    I’ll assign this to @lakchote, as it’s related to the search feature. He can decide whether to pass this to external or handle all these minor bugs in a single PR.

  9. 48 remaining items

  10. lakchote commented on Oct 1, 2024

    @lakchote
    Contributor

    Bump for payment @kadiealexander

  11. kadiealexander commented on Oct 2, 2024

    @kadiealexander
    Contributor

    @nkdengineer sent you an Upwork contract, sorry for the delay!

  12. kadiealexander commented on Oct 3, 2024

    @kadiealexander
    Contributor

    Let me know when you've accepted it please.

  13. DylanDylann commented on Oct 4, 2024

    @DylanDylann
    Contributor

    @lakchote @kadiealexander I reviewed the PR. Please assign me to this issue and also help to process payment for me. Thanks

  14. nkdengineer commented on Oct 4, 2024

    @nkdengineer
    Contributor

    Let me know when you've accepted it please.

    @kadiealexander I just accepted 👍

  15. DylanDylann commented on Oct 7, 2024

    @DylanDylann
    Contributor

    @kadiealexander could you also kindly take care of the payment for me? since I've already reviewed the PR. Thanks so much! 🙏

    cc @lakchote

  16. kadiealexander commented on Oct 7, 2024

    @kadiealexander
    Contributor

    @DylanDylann please accept the offer

  17. DylanDylann commented on Oct 8, 2024

    @DylanDylann
    Contributor

    @kadiealexander I accepted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions