Skip to content

[HOLD for payment 2024-10-14] [$250] LHN - Members' room names are not updated in LHN after cache deletion #49260

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.34-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4960406
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause Internal Team

Action Performed:

Prerequisites:
Create a WS and add two employees to it

Steps:

  1. Open NewExpensify app
  2. Log in with a WS administrator account
  3. Go to the account settings
  4. Go to the Troubleshoot menu
  5. Click on “Clear cache and restart” and clear the cache
  6. Go back to the LHN Inbox

Expected Result:

Members' room names should be updated and display the room name in LHN after the cache is deleted

Actual Result:

Members' room names are not updated in LHN after cache deletion

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6602770_1726253910821.Recording__1601.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836832143423032683
  • Upwork Job ID: 1836832143423032683
  • Last Price Increase: 2024-09-26
  • Automatic offers:
    • ikevin127 | Reviewer | 104231232
    • truph01 | Contributor | 104231233
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 16, 2024
  2. melvin-bot commented on Sep 16, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Sep 16, 2024

    @IuliiaHerets
    Author

    @zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. melvin-bot commented on Sep 19, 2024

    @melvin-bot

    @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. zanyrenney commented on Sep 19, 2024

    @zanyrenney
    Contributor

    whoops!!!

  6. zanyrenney commented on Sep 19, 2024

    @zanyrenney
    Contributor

    yeh i agree this is a bug. we should look at this in ND quality.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 19, 2024
  8. changed the title [-]LHN - Members' room names are not updated in LHN after cache deletion[/-] [+][$250] LHN - Members' room names are not updated in LHN after cache deletion[/+] on Sep 19, 2024
  9. melvin-bot commented on Sep 19, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 19, 2024
  11. 39 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 7, 2024
  13. changed the title [-][$250] LHN - Members' room names are not updated in LHN after cache deletion[/-] [+][HOLD for payment 2024-10-14] [$250] LHN - Members' room names are not updated in LHN after cache deletion[/+] on Oct 7, 2024
  14. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-14. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. ikevin127 commented on Oct 11, 2024

    @ikevin127
    Contributor
    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: Add cache to getReportName #47156.
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add cache to getReportName #47156 (comment).
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Prerequisites:

    • Create a WS and add two employees to it.
    1. Open NewExpensify app.
    2. Log in with a WS admin account.
    3. Go to the account settings.
    4. Go to the Troubleshoot menu.
    5. Click on Clear cache and restart to clear the cache.
    6. Go back to the LHN Inbox.
    7. Verify that members' room names should be updated and display the room name in LHN after the cache is deleted, instead of showing default Chat Report name.

    Do we agree 👍 or 👎.

  18. zanyrenney commented on Oct 14, 2024

    @zanyrenney
    Contributor
  19. zanyrenney commented on Oct 14, 2024

    @zanyrenney
    Contributor

    payment summary

    @ikevin127 requires payment automatic offer (Reviewer) - paid via Upwork $250
    @truph01 requires payment automatic offer (Contributor) - paid via Upwork $250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions