You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-14] [$250] LHN - Members' room names are not updated in LHN after cache deletion #49260
Version Number: 9.0.34-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4960406 Email or phone of affected tester (no customers):sustinov@applausemail.com Issue reported by: Applause Internal Team
Action Performed:
Prerequisites:
Create a WS and add two employees to it
Steps:
Open NewExpensify app
Log in with a WS administrator account
Go to the account settings
Go to the Troubleshoot menu
Click on “Clear cache and restart” and clear the cache
Go back to the LHN Inbox
Expected Result:
Members' room names should be updated and display the room name in LHN after the cache is deleted
Actual Result:
Members' room names are not updated in LHN after cache deletion
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]LHN - Members' room names are not updated in LHN after cache deletion[/-][+][$250] LHN - Members' room names are not updated in LHN after cache deletion[/+]on Sep 19, 2024
changed the title [-][$250] LHN - Members' room names are not updated in LHN after cache deletion[/-][+][HOLD for payment 2024-10-14] [$250] LHN - Members' room names are not updated in LHN after cache deletion[/+]on Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Prerequisites:
Create a WS and add two employees to it.
Open NewExpensify app.
Log in with a WS admin account.
Go to the account settings.
Go to the Troubleshoot menu.
Click on Clear cache and restart to clear the cache.
Go back to the LHN Inbox.
Verify that members' room names should be updated and display the room name in LHN after the cache is deleted, instead of showing default Chat Report name.
Activity
melvin-bot commentedon Sep 16, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 16, 2024
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Sep 19, 2024
@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
zanyrenney commentedon Sep 19, 2024
whoops!!!
zanyrenney commentedon Sep 19, 2024
yeh i agree this is a bug. we should look at this in ND quality.
[-]LHN - Members' room names are not updated in LHN after cache deletion[/-][+][$250] LHN - Members' room names are not updated in LHN after cache deletion[/+]melvin-bot commentedon Sep 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021836832143423032683
39 remaining items
[-][$250] LHN - Members' room names are not updated in LHN after cache deletion[/-][+][HOLD for payment 2024-10-14] [$250] LHN - Members' room names are not updated in LHN after cache deletion[/+]melvin-bot commentedon Oct 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ikevin127 commentedon Oct 11, 2024
Regression Test Proposal
Prerequisites:
Clear cache and restartto clear the cache.Chat Reportname.Do we agree 👍 or 👎.
zanyrenney commentedon Oct 14, 2024
#50727
zanyrenney commentedon Oct 14, 2024
payment summary
@ikevin127 requires payment automatic offer (Reviewer) - paid via Upwork $250
@truph01 requires payment automatic offer (Contributor) - paid via Upwork $250