Skip to content

[Search v2.3] Make the popover menu modal closable by swiping down #49441

Closed

Description

@lakchote

See #48566 (comment)

Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 19, 2024
  2. self-assigned this
    on Sep 19, 2024
  3. melvin-bot commented on Sep 19, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

  4. nkdengineer commented on Sep 19, 2024

    @nkdengineer
    Contributor

    @lakchote What is the swiping-down action? It would be helpful to have an example video about this bug.

  5. lakchote commented on Sep 19, 2024

    @lakchote
    ContributorAuthor

    @lakchote What is the swiping-down action? It would be helpful to have an example video about this bug.

    I've retested it, and this fixed it.
    https://github.com/user-attachments/assets/a9f89dde-6e46-4e6e-b3f7-a3b2d28717d7

    Previously, we weren't able to close the modal down by swiping downwars from the header.

    Discussed it with @jjcoffee and we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions