[Payment 2024-11-07] [$250] mWeb - Group chat - Not here page appears briefly when last member leave the group chat

@strepanier03

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4985233&group_by=cases:section_id&group_order=asc&group_id=229067
Email or phone of affected tester (no customers): gocemate+a2197@gmail.com
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

Create a group chat
Click on the header
Remove all existing members from the group
Click Leave the group
Confirm leaving the group participant

Expected Result:

There should be no error page

Actual Result:

Not here page appears briefly when last member leave the group chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6608577_1726732763600.Recording__3970.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836833773766101729
Upwork Job ID: 1836833773766101729
Last Price Increase: 2024-10-10
Automatic offers:

wildan-m | Contributor | 104431872

Issue Owner

Current Issue Owner: @strepanier03

@strepanier03

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@strepanier03

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-09-19 14:29:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Group chat - Not here page appears briefly when last member leave the group chat

What is the root cause of that problem?

We dismissModal and then call the leaveGroupChat here

App/src/pages/ReportDetailsPage.tsx

Lines 222 to 225 in 3657a67

    
           Navigation.dismissModal(); 
        
           Navigation.isNavigationReady().then(() => { 
        
               if (isRootGroupChat) { 
        
                   Report.leaveGroupChat(report.reportID);

We are deleting the report optimistically before navigating to recent chat in leaveGroupChat

App/src/libs/actions/Report.ts

Line 2795 in 3657a67

navigateToMostRecentReport(report);

hence if the navigation is not quick enough we will see a not found page as the group chat is deleted in onyx

What changes do you think we should make in order to solve the problem?

We should execute the deleting code after the navigateToMostRecentReport has finished.
We can do that by either calling navigateToMostRecentReport first and call the optimistic code and api call after/in

isNavigationReady
InteractionManager.runAfterInteractions
after some custom set timeout

A similar method can used for leaveRoom too.

What alternative solutions did you explore? (Optional)

Edited by proposal-police: This proposal was edited at 2024-09-19 17:43:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page appears briefly when last member leave the group chat

What is the root cause of that problem?

We're waiting for dismissModal navigation to trigger Report.leaveGroupChat(report.reportID)

so we can see the not found page for a shot time

What changes do you think we should make in order to solve the problem?

After dismissModal, we should call goBack to remove the group/thread chat (because that group/thread will be deleted). We just did the same in here

    const leaveChat = useCallback(() => {
        Navigation.dismissModal();
        Navigation.goBack()
        Navigation.isNavigationReady().then(() => {

Then Report.leaveGroupChat(report.reportID) will open the latest report

Change

App/src/libs/actions/Report.ts

Line 2739 in 10ea08e

Navigation.goBack(lastAccessedReportRoute);

to

Navigation.navigate(lastAccessedReportRoute);

We need to remove these lines since we already goBack before

What alternative solutions did you explore? (Optional)

We can consider to remove Navigation.isNavigationReady() in here. I tested this issue and the bug that needs isNavigationReady and they worked well

Result

Screen.Recording.2024-09-26.at.15.33.14.mov

Job added to Upwork: https://www.upwork.com/jobs/~021836833773766101729

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Reviewing..

@parasharrajat

@parasharrajat @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@wildan-m

Payment Summary

$250 - @wildan-m via Upwork PAID (Contributor)
$250 - @parasharrajat via New Expensify Manual Requests

@parasharrajat

@parasharrajat - I'll check in later for the checklist. Once it's done I'll make the reg test and remove the hold from the payment summary.

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: [Group Chats] Add remaining features #39757
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/39757/files#r1833788737
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Create a group chat
Click on the header
Remove all existing members from the group
Click Leave the group
Confirm leaving the group participant
Verify no "not found" page appeared

Do you agree 👍 or 👎 ?

@parasharrajat

All right @parasharrajat thanks for doing that checklist! I have removed the hold from the payment summary so feel free to request payment. Thanks again!

Payment requested as per #49468 (comment)

@parasharrajat

$250 approved for @parasharrajat

Navigation Menu

Repository navigation

[Payment 2024-11-07] [$250] mWeb - Group chat - Not here page appears briefly when last member leave the group chat #49468

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

51 remaining items

Payment Summary

Regression Test Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	Navigation.dismissModal();
	Navigation.isNavigationReady().then(() => {
	if (isRootGroupChat) {
	Report.leaveGroupChat(report.reportID);

[Payment 2024-11-07] [$250] mWeb - Group chat - Not here page appears briefly when last member leave the group chat #49468

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 19, 2024

IuliiaHerets commented on Sep 19, 2024

FitseTLT commented on Sep 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dominictb commented on Sep 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot commented on Sep 19, 2024

melvin-bot commented on Sep 19, 2024

parasharrajat commented on Sep 19, 2024

51 remaining items

melvin-bot commented on Oct 31, 2024

strepanier03 commented on Nov 7, 2024

strepanier03 commented on Nov 7, 2024

Payment Summary

strepanier03 commented on Nov 7, 2024

parasharrajat commented on Nov 8, 2024

Regression Test Steps

strepanier03 commented on Nov 8, 2024

parasharrajat commented on Dec 12, 2024

JmillsExpensify commented on Dec 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions