[Hold for payment 2024-10-06][$250] Android - expense-On opening 1st expense with 1:1 user, receipt placeholder flickers

@rayane-djouah

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Launch app
Login to a new gmail account
Open 1: DM with a user
Create a expense
Open the expense
Note the receipt placeholder

Expected Result:

Receipt placeholder must not flicker.

Actual Result:

Only in gmail Android app,on opening 1st expense with 1:1 user, receipt placeholder flickers.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6608645_1726737271354.screenrecorder-2024-09-19-00-42-48-602_compress_1.2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021837170951789576068
Upwork Job ID: 1837170951789576068
Last Price Increase: 2024-09-20
Automatic offers:

rayane-djouah | Reviewer | 104094404
nkdengineer | Contributor | 104094406

Issue Owner

Current Issue Owner: @rayane-djouah

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isabelastisser

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Job added to Upwork: https://www.upwork.com/jobs/~021837170951789576068

@rayane-djouah

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

Waiting on proposals

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only in gmail Android app,on opening 1st expense with 1:1 user, receipt placeholder flickers.

What is the root cause of that problem?

Here is the log when adding a useEffect in MoneyRequestView

useEffect(() => {
    console.log("LOGMOUNT");
    return () => {
        console.log("LOGUNMOUNT");
    }
}, [])

This component is mounted and unmounted several times.

This happens because the deprecated withOnyx HOC in ReportActionsView that cause the weird lifecycle of the component

App/src/pages/home/report/ReportActionsView.tsx

Line 552 in bbc0919

withOnyx<ReportActionsViewProps, ReportActionsViewOnyxProps>({

What changes do you think we should make in order to solve the problem?

Remove withOnyx in ReportActionsView and use useOnyx hook instead.

OPTIONAL: We can also do this for ReportActionsItem

App/src/pages/home/report/ReportActionsView.tsx

Line 552 in bbc0919

withOnyx<ReportActionsViewProps, ReportActionsViewOnyxProps>({

The test branch here.

What alternative solutions did you explore? (Optional)

@rayane-djouah

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@nkdengineer

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

BugZero Checklist

The PR that introduced the bug has been identified. Link to the PR: The issue was caused by the use of withOnyx, which is now deprecated. We are in the process of migrating to the useOnyx hook, so no specific PR is responsible for this bug.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. While I believe this is unnecessary since the migration to the useOnyx hook should prevent this issue from reoccurring, I've included a proposal in case we decide to proceed with a regression test.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Create a new account
Open a DM with a user
Create an expense
Open the expense
Verify that the receipt placeholder does not flicker

Do we agree 👍 or 👎

@thienlnam

@thienlnam, can you please review the test proposal? Thanks!

@rayane-djouah

@rayane-djouah @nkdengineer I processed the payments in Upwork. Thanks!

All set!

Navigation Menu

Repository navigation

[Hold for payment 2024-10-06][$250] Android - expense-On opening 1st expense with 1:1 user, receipt placeholder flickers #49470

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

3 remaining items

BugZero Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Hold for payment 2024-10-06][$250] Android - expense-On opening 1st expense with 1:1 user, receipt placeholder flickers #49470

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 19, 2024

IuliiaHerets commented on Sep 19, 2024

melvin-bot commented on Sep 20, 2024

melvin-bot commented on Sep 20, 2024

rayane-d commented on Sep 23, 2024

nkdengineer commented on Sep 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

3 remaining items

melvin-bot commented on Sep 23, 2024

melvin-bot commented on Sep 23, 2024

rayane-d commented on Oct 6, 2024

BugZero Checklist

isabelastisser commented on Oct 7, 2024

isabelastisser commented on Oct 7, 2024

isabelastisser commented on Oct 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions