Skip to content

[HOLD for payment 2024-10-14] [$250] Android - Pronouns -Pronouns title move from left to right above the input field #49488

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.38-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4987781
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. Tap profile icon -- profile -- pronouns
  3. Select a pronouns
  4. Tap on "pronouns" section
  5. Note pronouns title about input field

Expected Result:

Pronouns title must not move from left to right above the input field.

Actual Result:

Pronouns title move from left to right above the input field.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6608843_1726747987981.Screenrecorder-2024-09-19-17-38-19-362_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021837158444786308014
  • Upwork Job ID: 1837158444786308014
  • Last Price Increase: 2024-09-20
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 19, 2024
  2. melvin-bot commented on Sep 19, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Sep 19, 2024

    @IuliiaHerets
    Author

    @lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. daledah commented on Sep 20, 2024

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Pronouns title move from left to right above the input field.

    What is the root cause of that problem?

    We're initing the searchValue as empty

    const [searchValue, setSearchValue] = useState('');

    then update with selected value in

    setSearchValue(currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : '');

    and we have the animation to move the label (translateX and translateY) if the searchValue change from empty to selected value

    labelScale.interpolate({
    inputRange: [styleConst.ACTIVE_LABEL_SCALE, styleConst.INACTIVE_LABEL_SCALE],
    outputRange: [-(width - width * styleConst.ACTIVE_LABEL_SCALE) / 2, 0],
    }),

    What changes do you think we should make in order to solve the problem?

    We should init the searchValue with selected pronoun

        const [searchValue, setSearchValue] = useState(()=>{
            const currentPronounsText = CONST.PRONOUNS_LIST.find((value) => value === currentPronounsKey);
            return currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : ''
        });
    

    we can create the function to get the search value to prevent duplicated code

    What alternative solutions did you explore? (Optional)

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 20, 2024
  6. changed the title [-]Android - Pronouns -Pronouns title move from left to right above the input field[/-] [+][$250] Android - Pronouns -Pronouns title move from left to right above the input field[/+] on Sep 20, 2024
  7. melvin-bot commented on Sep 20, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 20, 2024
  9. melvin-bot commented on Sep 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  10. daledah commented on Sep 23, 2024

    @daledah
    Contributor

    @getusha What do you think about my proposal?

  11. melvin-bot commented on Sep 23, 2024

    @melvin-bot

    @lschurr, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. 26 remaining items

  13. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @bernhardoj requires payment through NewDot Manual Requests
    • @getusha requires payment through NewDot Manual Requests
  15. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
    • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@getusha] Determine if we should create a regression test for this bug.
    • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@lschurr)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1837158444786308014/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. lschurr commented on Oct 14, 2024

    @lschurr
    Contributor

    Payment summary is correct - please request payment in NewDot @bernhardoj @getusha :)

  18. bernhardoj commented on Oct 15, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  19. JmillsExpensify commented on Oct 15, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  20. getusha commented on Oct 28, 2024

    @getusha
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@getusha] The PR that introduced the bug has been identified. Link to the PR: I don't think it's a regression we reverted a workaround for similar issue that was used previously
    [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
    [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    [@getusha] Determine if we should create a regression test for this bug. No I don't think it affects any user flow
    [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a

  21. garrettmknight commented on Oct 29, 2024

    @garrettmknight
    Contributor

    $250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions