You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-14] [$250] Android - Pronouns -Pronouns title move from left to right above the input field #49488
Version Number: v9.0.38-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4987781 Issue reported by: Applause Internal Team
Action Performed:
Launch app
Tap profile icon -- profile -- pronouns
Select a pronouns
Tap on "pronouns" section
Note pronouns title about input field
Expected Result:
Pronouns title must not move from left to right above the input field.
Actual Result:
Pronouns title move from left to right above the input field.
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Android - Pronouns -Pronouns title move from left to right above the input field[/-][+][$250] Android - Pronouns -Pronouns title move from left to right above the input field[/+]on Sep 20, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR:
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug.
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: I don't think it's a regression we reverted a workaround for similar issue that was used previously
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug. No I don't think it affects any user flow
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a
Activity
melvin-bot commentedon Sep 19, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 19, 2024
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
daledah commentedon Sep 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pronouns title move from left to right above the input field.
What is the root cause of that problem?
We're initing the searchValue as empty
App/src/pages/settings/Profile/PronounsPage.tsx
Line 34 in d009d8e
then update with selected value in
App/src/pages/settings/Profile/PronounsPage.tsx
Line 42 in d009d8e
and we have the animation to move the label (translateX and translateY) if the
searchValuechange from empty to selected valueApp/src/components/TextInput/TextInputLabel/index.native.tsx
Lines 21 to 24 in d009d8e
What changes do you think we should make in order to solve the problem?
We should init the searchValue with selected pronoun
we can create the function to get the search value to prevent duplicated code
What alternative solutions did you explore? (Optional)
[-]Android - Pronouns -Pronouns title move from left to right above the input field[/-][+][$250] Android - Pronouns -Pronouns title move from left to right above the input field[/+]melvin-bot commentedon Sep 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021837158444786308014
melvin-bot commentedon Sep 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)daledah commentedon Sep 23, 2024
@getusha What do you think about my proposal?
melvin-bot commentedon Sep 23, 2024
@lschurr, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!
26 remaining items
melvin-bot commentedon Oct 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@lschurr)
lschurr commentedon Oct 14, 2024
Payment summary is correct - please request payment in NewDot @bernhardoj @getusha :)
bernhardoj commentedon Oct 15, 2024
Requested in ND.
JmillsExpensify commentedon Oct 15, 2024
$250 approved for @bernhardoj
getusha commentedon Oct 28, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: I don't think it's a regression we reverted a workaround for similar issue that was used previously
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug. No I don't think it affects any user flow
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a
garrettmknight commentedon Oct 29, 2024
$250 approved for @getusha