[$250] Group chat - After removing user, group name is not updated

@twisterdotcom

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Launch app
Tap fab -- start chat
Select a user with a custom name eg: jaihanumanblog@gmail.com
and tap add to group
Open the group name and note user name shown
Select the user and now note the group name updated without user name
Tap back
Select a user with a custom name eg: jaihanumanblog@gmail.com
and tap add to group
Tal start group
Tap header
Tap the group name and note user name shown
Remove the user
Tap group name and note group name not updated without user name and just a swipe down shows character limit error

Expected Result:

After removing user, group name must be updated.

Actual Result:

After removing user, group name is not updated.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6608614_1726735802186.Screenrecorder-2024-09-19-14-10-17-185_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836866126068088205
Upwork Job ID: 1836866126068088205
Last Price Increase: 2024-09-19
Automatic offers:

c3024 | Reviewer | 104061081
FitseTLT | Contributor | 104061083

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@twisterdotcom

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Job added to Upwork: https://www.upwork.com/jobs/~021836866126068088205

@c3024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

what should happen if the user changed the group name to something else before removing a user?

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - After removing user, group name is not updated

What is the root cause of that problem?

We are not removing pending delete participants when we construct a default (when there is no custom group name) group name here

App/src/libs/ReportUtils.ts

Line 2163 in 98dc643

    
           let participantAccountIDs = participants?.map((participant) => participant.accountID) ?? Object.keys(report?.participants ?? {}).map(Number);

What changes do you think we should make in order to solve the problem?

We should filter out participants with pending delete from report.participants

    let participantAccountIDs =
        participants?.map((participant) => participant.accountID) ??
        Object.keys(report?.participants ?? {})
            .map(Number)
            .filter((accountID) => {
                const pendingMember = report?.pendingChatMembers?.find((member) => member.accountID === accountID.toString());
                return !(pendingMember && pendingMember.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
            });

What alternative solutions did you explore? (Optional)

@FitseTLT

@FitseTLT 's proposal here LGTM!

🎀 👀 🎀 C+ Reviewed

@FitseTLT

Let us know how you're getting on @FitseTLT!

@bondydaa

@bondydaa, @twisterdotcom, @FitseTLT, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

PR created

hmm automation failed looks like this was deployed 2 weeks ago #49618 (comment)

@c3024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@c3024] The PR that introduced the bug has been identified. Link to the PR: fix: New users are not displayed in group name #46703

[@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/46703/files#r1801578029

[@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this could not have been identified earlier.

[@c3024] Determine if we should create a regression test for this bug. Yes

[@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

FAB > Start chat
Select a few members and create a group chat
Go to the group chat report
Click on the group chat header
Press on "Members" in the right hand panel
Select a member and remove them from the group
Verify that the group chat name does not contain name/login of the removed user in Step 6

@twisterdotcom

@twisterdotcom

Can you please handle the payment here? Thanks!

@FitseTLT

Payment Summary:

@FitseTLT paid $250 via Upwork here (Contributor)
@c3024 paid $250 via Upwork here (C+)

Navigation Menu

Repository navigation

[$250] Group chat - After removing user, group name is not updated #49491

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

6 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Group chat - After removing user, group name is not updated #49491

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 19, 2024

IuliiaHerets commented on Sep 19, 2024

melvin-bot commented on Sep 19, 2024

melvin-bot commented on Sep 19, 2024

abzokhattab commented on Sep 19, 2024

FitseTLT commented on Sep 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

c3024 commented on Sep 20, 2024

6 remaining items

twisterdotcom commented on Sep 23, 2024

melvin-bot commented on Sep 23, 2024

FitseTLT commented on Sep 23, 2024

bondydaa commented on Oct 15, 2024

c3024 commented on Oct 15, 2024

Regression Test Proposal

c3024 commented on Oct 15, 2024

twisterdotcom commented on Oct 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions