You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-14] [$250] Search - Room mention in the message is not highlighted or linked when opened from Search #49494
Version Number: 9.0.38-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to a room.
Send a message containing #room mention.
Go to Search.
Go to Chat.
Click on the message sent in Step 3.
Expected Result:
The room mention in the message will be highlighted and linked when opened from Search.
Actual Result:
The room mention in the message is not highlighted or linked when opened from Search.
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
The room mention in the message is not highlighted or linked when opened from Search.
What is the root cause of that problem?
Currently, here the values of currentReportIDContext and currentReportID?.currentReportID are both -1 because we are not adding enough Provider and passing the correct reportID in the Search Page, which is why the value of isGroupPolicyReport is false, and we will not show the highlight for that message.
changed the title [-]Search - Room mention in the message is not highlighted or linked when opened from Search[/-][+][$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/+]on Sep 23, 2024
changed the title [-][$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/-][+][HOLD for payment 2024-10-14] [$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/+]on Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
This was not a regression but missing case while implementing Search v2.2 - chat type in search.
I think we'll add comprehensive regression tests after search project is done so no action required here.
Activity
melvin-bot commentedon Sep 19, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 19, 2024
We think that this bug might be related to #wave-control
IuliiaHerets commentedon Sep 19, 2024
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
nkdengineer commentedon Sep 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The room mention in the message is not highlighted or linked when opened from Search.
What is the root cause of that problem?
Currently, here the values of
currentReportIDContextandcurrentReportID?.currentReportIDare both-1because we are not adding enoughProviderand passing the correctreportIDin the Search Page, which is why the value ofisGroupPolicyReportisfalse, and we will not show the highlight for that message.App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Line 63 in b0ce206
What changes do you think we should make in order to solve the problem?
We should add
MentionReportContext.Providerfor items and pass in the valuementionReportContextValuelike we did here withChatListItemhere to highlight text in list all chatsApp/src/components/SelectionList/ChatListItem.tsx
Line 82 in b0ce206
ReportActionItemhereApp/src/pages/home/report/ReportActionItem.tsx
Line 905 in b0ce206
What alternative solutions did you explore? (Optional)
NA
result.mov
melvin-bot commentedon Sep 23, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021838252249332966020
[-]Search - Room mention in the message is not highlighted or linked when opened from Search[/-][+][$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/+]melvin-bot commentedon Sep 23, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)13 remaining items
[-][$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/-][+][HOLD for payment 2024-10-14] [$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/+]melvin-bot commentedon Oct 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
slafortune commentedon Oct 14, 2024
@situchan Can you please complete this checklist?
situchan commentedon Oct 15, 2024
This was not a regression but missing case while implementing Search v2.2 - chat type in search.
I think we'll add comprehensive regression tests after search project is done so no action required here.
slafortune commentedon Oct 15, 2024
@situchan Role - C+ - Paid $250 Via Upworks
@nkdengineer Role - Contributor - Paid $250 Via Upworks