Skip to content

[HOLD for payment 2024-10-14] [$250] Search - Room mention in the message is not highlighted or linked when opened from Search #49494

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to a room.
  3. Send a message containing #room mention.
  4. Go to Search.
  5. Go to Chat.
  6. Click on the message sent in Step 3.

Expected Result:

The room mention in the message will be highlighted and linked when opened from Search.

Actual Result:

The room mention in the message is not highlighted or linked when opened from Search.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6608683_1726739485892.bandicam_2024-09-19_17-47-50-037.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838252249332966020
  • Upwork Job ID: 1838252249332966020
  • Last Price Increase: 2024-09-23
  • Automatic offers:
    • situchan | Reviewer | 104118455
    • nkdengineer | Contributor | 104118456
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 19, 2024
  2. melvin-bot commented on Sep 19, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Sep 19, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-control

  4. IuliiaHerets commented on Sep 19, 2024

    @IuliiaHerets
    Author

    @slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. nkdengineer commented on Sep 19, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The room mention in the message is not highlighted or linked when opened from Search.

    What is the root cause of that problem?

    Currently, here the values of currentReportIDContext and currentReportID?.currentReportID are both -1 because we are not adding enough Provider and passing the correct reportID in the Search Page, which is why the value of isGroupPolicyReport is false, and we will not show the highlight for that message.

    const currentReportIDValue = currentReportIDContext || currentReportID?.currentReportID;

    What changes do you think we should make in order to solve the problem?

    We should add MentionReportContext.Provider for items and pass in the value mentionReportContextValue like we did here with

        const mentionReportContextValue = useMemo(() => ({currentReportID: report.reportID}), [report.reportID]);
    
    1. We can add this provider to ChatListItem here to highlight text in list all chats

    1. Also add this provider to ReportActionItem here

    <PressableWithSecondaryInteraction

    What alternative solutions did you explore? (Optional)

    NA

    result.mov
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 23, 2024
  7. melvin-bot commented on Sep 23, 2024

    @melvin-bot
  8. changed the title [-]Search - Room mention in the message is not highlighted or linked when opened from Search[/-] [+][$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/+] on Sep 23, 2024
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 23, 2024
  10. melvin-bot commented on Sep 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  11. 13 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 7, 2024
  13. changed the title [-][$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/-] [+][HOLD for payment 2024-10-14] [$250] Search - Room mention in the message is not highlighted or linked when opened from Search[/+] on Oct 7, 2024
  14. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-14. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. slafortune commented on Oct 14, 2024

    @slafortune
    Contributor

    @situchan Can you please complete this checklist?

  18. situchan commented on Oct 15, 2024

    @situchan
    Contributor

    This was not a regression but missing case while implementing Search v2.2 - chat type in search.
    I think we'll add comprehensive regression tests after search project is done so no action required here.

  19. slafortune commented on Oct 15, 2024

    @slafortune
    Contributor

    @situchan Role - C+ - Paid $250 Via Upworks
    @nkdengineer Role - Contributor - Paid $250 Via Upworks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions