Repository navigation
Account – Infinite loading spinner when closing an account #49532
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+shsb22acc1177@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Login with an account
- Navigate to account settings > Security > Close account
- Enter the reason and default contact method > Close > Confirm
Expected Result:
User is signed out from the app and the account is closed successfully
Actual Result:
Infinite loading spinner is displayed in the RHP and the user is not logged out from the app
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Sep 20, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 20, 2024
@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
abzokhattab commentedon Sep 20, 2024
i think this could be a backend issue .. as the backend returns an empty response and doesn't properly remove the account, as i still see the old chats after closing the account and login in again
daledah commentedon Sep 23, 2024
I believe #48696 is not the cause of this bug, as the changes in this PR only applies to Expensify Guide member. But I'll take a closer look regardless and will open a follow-up PR as soon as possible if this is actually a regression.
daledah commentedon Sep 23, 2024
This bug is reproduced in production:
Screen.Recording.2024-09-23.at.22.53.41.mov
melvin-bot commentedon Sep 23, 2024
@RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!
MonilBhavsar commentedon Sep 23, 2024
Thanks for confirming @daledah!
MonilBhavsar commentedon Sep 23, 2024
@jjcoffee were you looking at this bug? Do you mind if I assign you as a C+?
situchan commentedon Sep 23, 2024
If this is true, I would be C+ as regression. Not tested yet though.
MonilBhavsar commentedon Sep 23, 2024
I agree the PR could not be the reason as we're only subscribing guides to specific channel and since the user experiencing the issue is not a guide.
MonilBhavsar commentedon Sep 23, 2024
I had a look at the server side code and we're only returning pusher response for CloseAccount API command. I think we should return the API response too for the user taking an action and that should probably fix this issue. Will make a change and see if we still are able to reproduce the issue
RachCHopkins commentedon Sep 24, 2024
@MonilBhavsar I'll hold off on adding any labels here. Looks like it's potentially Internal?
MonilBhavsar commentedon Sep 24, 2024
Yes, this is internal issue
MonilBhavsar commentedon Sep 24, 2024
Got PR in review!
RachCHopkins commentedon Sep 30, 2024
Are there any steps left here @MonilBhavsar?
MonilBhavsar commentedon Sep 30, 2024
Thanks for the comment. No, this is fixed! We can close this as it was all internal