[$250] Room-A "workspace" visibility room is created via whisper from a "public" visibility room

@Christinadobrzyn

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/home
Tap fab -- start chat
Create a public visibility room
Create 2 room via whisper by sending message - eg : #35 #799
From the whisper message, tap yes
Note room created is highlighted
Now tap on room header -- settings -- visibility
Note room is a "public" visibility room
Now tap on any room highlighted ( created via whisper)
Now tap on room header -- settings -- visibility
Note room created is a workspace visibility room

Expected Result:

A "public" visibility room must be created via whisper from a "public" visibility room.

Actual Result:

A "workspace" visibility room is created via whisper from a "public" visibility room.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6609907_1726835399664.screenrecorder-2024-09-20-16-47-00-591_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021837194850505873695
Upwork Job ID: 1837194850505873695
Last Price Increase: 2024-09-20
Automatic offers:

DylanDylann | Reviewer | 104139929
nkdengineer | Contributor | 104139931

Issue Owner

Current Issue Owner: @Christinadobrzyn

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Christinadobrzyn

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I can reproduce this with the steps in the OP. I think this can be external - let's start there and see what we think!

Job added to Upwork: https://www.upwork.com/jobs/~021837194850505873695

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

A "workspace" visibility room is created via whisper from a "public" visibility room.

What is the root cause of that problem?

When we click on Yes, BE will create a room with visibility as restricted

What changes do you think we should make in order to solve the problem?

In this function, if resolution is created, we should create an optimistic room with visibility as the visibility of the current report and a created action for this room in optimistic data (Also reset it in failure data).

App/src/libs/actions/Report.ts

Lines 3883 to 3887 in 513e6b3

    
           function resolveActionableReportMentionWhisper( 
        
               reportId: string, 
        
               reportAction: OnyxEntry<ReportAction>, 
        
               resolution: ValueOf<typeof CONST.REPORT.ACTIONABLE_REPORT_MENTION_WHISPER_RESOLUTION>, 
        
           ) {

Then we can pass the reportID and visibility of the new room as a param of ResolveActionableReportMentionWhisper API. BE will use this reportID and visibility to create a new room.

What alternative solutions did you explore? (Optional)

If we don't want to create an optimistic room, we can pass visibility param to ResolveActionableReportMentionWhisper API then BE can use this to create the room with the correct visibility.

@Christinadobrzyn

@Christinadobrzyn, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@justinpersaud

@justinpersaud If the report was created, please send the preexistingReportID as the existing reportID for the report data of the reportID according to the room name in the API param. And then frontend already have the logic the clear the optimistic report.

@justinpersaud

@justinpersaud Could you help to check the above comment? Thanks

Yeah, just trying to prioritize when we'll get the backend change done. I haven't had a chance to do it just yet with other priorities.

I'm wrapping up some other tasks right now internally, but hoping to look at the backend changes required later this week

@justinpersaud

@justinpersaud Kindly bump

Looked at the backend change just now and see we are defaulting to workspace visibility as we reported here, but I am asking if there is a specific reason why in our product channel

@DylanDylann

@DylanDylann @nkdengineer I am newer to working on these proposals so you'll have to bear with me here, but why are we passing in reportIDList, implying we would pass a number of reportIDs to the backend, right?

Won't we ever only be sending a single reportID to the backend to be created? Or are we going to queue up a backend call to ResolveActionableReportMentionWhisper with multiple reportIDs?

@DylanDylann

@DylanDylann and @nkdengineer can you follow up on this - #49544 (comment)

@justinpersaud

Won't we ever only be sending a single reportID to the backend to be created? Or are we going to queue up a backend call to ResolveActionableReportMentionWhisper with multiple reportIDs?

@justinpersaud I will send an array of reportIDs because ResolveActionableReportMentionWhisper can have multiple new rooms.

@Christinadobrzyn

Hey all,

I circled back internally and discovered this feature is actually working as designed. We want the visibility of rooms to always be set to workspace, regardless of where it is created by default.

Thanks for the initial work and investigation. I'll leave it with @Christinadobrzyn for any outstanding payment for work that was already done.

@justinpersaud

Ah thanks @justinpersaud!
It looks like a PR was created but not merged to production so our standard reasoning for payment isn't applicable.

@DylanDylann @nkdengineer let me know if there's anything compensation you feel should be considered for the work you spent. Thanks!

@Christinadobrzyn

@Christinadobrzyn From https://expensify.slack.com/archives/C02NK2DQWUX/p1723055151068559?thread_ts=1723015261.405329&cid=C02NK2DQWUX, I think we should get full compensation

@nkdengineer

Okay sounds reasonable since the proposals were reviewed and the PR was created.

Payouts due:

Contributor: $250 @nkdengineer (paid in Upwork - https://www.upwork.com/nx/wm/offer/104139931)
Reviewer: $250 @DylanDylann (paid in Upwork - https://www.upwork.com/nx/wm/workroom/38546784/details)

No regression test needed. Closing this out!

Navigation Menu

Repository navigation

[$250] Room-A "workspace" visibility room is created via whisper from a "public" visibility room #49544

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function resolveActionableReportMentionWhisper(
	reportId: string,
	reportAction: OnyxEntry<ReportAction>,
	resolution: ValueOf<typeof CONST.REPORT.ACTIONABLE_REPORT_MENTION_WHISPER_RESOLUTION>,
	) {

[$250] Room-A "workspace" visibility room is created via whisper from a "public" visibility room #49544

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 20, 2024

IuliiaHerets commented on Sep 20, 2024

Christinadobrzyn commented on Sep 20, 2024

melvin-bot commented on Sep 20, 2024

melvin-bot commented on Sep 20, 2024

nkdengineer commented on Sep 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 23, 2024

24 remaining items

nkdengineer commented on Oct 15, 2024

DylanDylann commented on Oct 17, 2024

justinpersaud commented on Oct 17, 2024

justinpersaud commented on Oct 22, 2024

DylanDylann commented on Oct 28, 2024

justinpersaud commented on Oct 28, 2024

justinpersaud commented on Oct 28, 2024

Christinadobrzyn commented on Oct 29, 2024

nkdengineer commented on Oct 29, 2024

justinpersaud commented on Oct 29, 2024

Christinadobrzyn commented on Oct 30, 2024

DylanDylann commented on Oct 30, 2024

Christinadobrzyn commented on Oct 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions