Skip to content

[$250] [A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit #49593

Closed

Description

@grgia

We encountered a ton of lint errors in implementing combinedTrackSubmit
see PR - #49007

Let's fix those in a separate PR for clearer testing

cc @fabioh8010

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838165122581338960
  • Upwork Job ID: 1838165122581338960
  • Last Price Increase: 2024-11-12
  • Automatic offers:
    • shubham1206agra | Reviewer | 104148899
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 23, 2024
  2. self-assigned this
    on Sep 23, 2024
  3. melvin-bot commented on Sep 23, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. changed the title [-][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackExpense[/-] [+][A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackExpense[/+] on Sep 23, 2024
  5. changed the title [-][A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackExpense[/-] [+][A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/+] on Sep 23, 2024
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 23, 2024
  7. changed the title [-][A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/-] [+][$250] [A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/+] on Sep 23, 2024
  8. melvin-bot commented on Sep 23, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 23, 2024
  10. melvin-bot commented on Sep 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 23, 2024
  12. changed the title [-][$250] [A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/-] [+][A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/+] on Sep 23, 2024
  13. 47 remaining items

  14. grgia commented on Nov 11, 2024

    @grgia
    ContributorAuthor

    @shubham1206agra could you point to which review requires payment cc @johncschuster

  15. johncschuster commented on Nov 11, 2024

    @johncschuster
    Contributor

    @shubham1206agra thanks for raising that! Just to make sure we're all on the same page, are you referring to this?:

    If a contributor has been hired for a job and we decide to close the job before it is successfully completed
    50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned.

    Or is there something else you're referring to?

  16. shubham1206agra commented on Nov 12, 2024

    @shubham1206agra
    Contributor

    @shubham1206agra thanks for raising that! Just to make sure we're all on the same page, are you referring to this?:

    If a contributor has been hired for a job and we decide to close the job before it is successfully completed
    50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned.

    Or is there something else you're referring to?

    @johncschuster I believe it might fall under 100% due if contributor drafted a PR and requested a review.

    Since the deploy blocker revert happened due to some unrelated issue that just got discovered when we did migration, and it was not happening on my testing for some reason.

  17. melvin-bot commented on Nov 12, 2024

    @melvin-bot

    Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

  18. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 12, 2024
  19. changed the title [-][A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/-] [+][$250] [A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit[/+] on Nov 12, 2024
  20. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 12, 2024
  21. melvin-bot commented on Nov 12, 2024

    @melvin-bot

    Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

  22. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 12, 2024
  23. johncschuster commented on Nov 12, 2024

    @johncschuster
    Contributor

    Darn, I was trying to get a new Upwork link to auto-generate since the previous job expired 😅 . I'll copy the old one now.

  24. johncschuster commented on Nov 12, 2024

    @johncschuster
    Contributor

    Payment Summary:

    Contributor: @fabioh8010 does not require payment (Contractor)

    Contributor+: @shubham1206agra paid $250 via Upwork

    Upwork job here! Please apply

  25. johncschuster commented on Nov 12, 2024

    @johncschuster
    Contributor

    Paid! Thanks for your work here, everyone! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions