[Due for payment 2025-02-25] Whisper to admin and auditor when their role is changed to user

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: N/A
Reproducible in staging?: N
Reproducible in production?: N
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1727169064223989?thread_ts=1726494273.889699&cid=C06ML6X0W9L

Problem

When we change a user's role from Admin or Auditor to user we remove them from all workspace chats they had access to, except for their own. Since they've been removed from the #admins room for the workspace, they won't have any context on their role change or why they no longer have access to the chats they once did.

Solution

Similar to how we handle approvers who are removed from workspace chats (PR for that here), we'll send a whisper to admins and auditors in their workspace chat when their role is updated and access to other workspace chats is removed.

Admin copy for the whisper:

[Admin] updated your role in [Workspace Name] from admin to user. You have been removed from all submitter workspace chats except for your own.

Auditor copy for the whisper:

[Admin] updated your role in [Workspace Name] from auditor to user. You have been removed from all submitter workspace chats except for your own.

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Remains a hot pick, waiting to be picked up

Reviewing label has been removed, please complete the "BugZero Checklist".

@heekinho

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Add support for demotion from workspace action report #56288

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

@heekinho requires payment (Needs manual offer from BZ)

@heekinho

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@heekinho] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@heekinho

@heekinho please complete the step here #49634 (comment)

@heekinho

Payment Summary

Upwork Job

ROLE: @heekinho paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@flodnv

@flodnv I'm not sure this apply to this PR?
I don't have access to TestRail, I read the recommendations and I'm unsure how to proceed here.
This is not a bug fix, it's a feature implementation. Nonetheless, I think the steps on the PR should be the ones to follow here, if necessary.

Feature: Whisper to admin and auditor when their role is changed to user

Proposed Test Steps:

Create an user account. This will be owner of the workspace.
Create another account in a second browser (or incognito mode), this will be the guest of the owner's workspace.
In the first browser (owner), create a workspace (Settings > Workspace > New Workspace). Give it a name and confirm.
In the just created workspace page, click the "Invite" button
Invite the second account by typing their email and then select Admin for the role.
The workspace should automatically appear on the second account. You can see a welcome message in the workspace.
In the first account, select the invited user in the members page (Settings > Workspaces > Workspace > Members)
In the window that opened, change the role from Admin to User
The whisper notice should appear in the workspace of the invited user

Do we agree 👍 or 👎

@heekinho

Those look good to me, thanks @heekinho. Opened https://github.com/Expensify/Expensify/issues/474124. Closing this out.

Yep, thanks!

Navigation Menu

Repository navigation

[Due for payment 2025-02-25] Whisper to admin and auditor when their role is changed to user #49634

Problem

Solution

Platforms:

Screenshots/Videos

72 remaining items

Payment Summary

BugZero Checklist (@bfitzexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2025-02-25] Whisper to admin and auditor when their role is changed to user #49634

Description

Problem

Solution

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 24, 2024

bfitzexpensify commented on Oct 1, 2024

bfitzexpensify commented on Oct 10, 2024

72 remaining items

melvin-bot commented on Feb 18, 2025

melvin-bot commented on Feb 18, 2025

melvin-bot commented on Feb 18, 2025

bfitzexpensify commented on Feb 24, 2025

melvin-bot commented on Feb 25, 2025

Payment Summary

BugZero Checklist (@bfitzexpensify)

heekinho commented on Feb 25, 2025

bfitzexpensify commented on Feb 25, 2025

flodnv commented on Feb 25, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions