You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-14] [$250] NetSuite - "Can't connect to NetSuite" message appears after connecting #49752
Version Number: 9.0.40-0 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR:#48918 Issue reported by: Applause Internal Team
@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Edited by proposal-police: This proposal was edited at 2024-09-26 02:19:00 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
NetSuite - "Can't connect to NetSuite" message appears after connecting
What is the root cause of that problem?
In here, we're showing the error if policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === false, this logic was added to show the authentication error if the user enters the wrong credentials in this PR (#47059). However, this logic is redundant since we already have a condition to check wrong credentials right before this block here:
Because of that, when 2 Pusher events arrived later. We will briefly see the error because the connection object contains verified: false and the other contains verified: true.
What changes do you think we should make in order to solve the problem?
Remove policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === false from this condition since it's redundant.
After that, we also need to update hasSynchronizationErrorMessage to handle the logic of showing RBR as well.
What alternative solutions did you explore? (Optional)
As I checked, the response of NetSuite connection is almost the same as other connections, we can consider removing this condition and handling Netsuite like other connections.
We also need to update hasSynchronizationErrorMessage to handle the logic of showing RBR as well.
changed the title [-]NetSuite - "Can't connect to NetSuite" message appears after connecting[/-][+][$250] NetSuite - "Can't connect to NetSuite" message appears after connecting[/+]on Sep 30, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws / @hungvu193] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws / @hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws / @hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws / @hungvu193] Determine if we should create a regression test for this bug.
[@Ollyws / @hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
Determine if we should create a regression test for this bug.
Yes.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
1. Login with any account.
2. Create a new WS.
3. Go to that workspace setting => More Features => Enable Accounting feature.
4. Go to Accounting, click NetSuite.
5. Enter NetSuite credentials.
6. Verify you can connect with NetSuite without any issue.
Activity
melvin-bot commentedon Sep 25, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 25, 2024
We think that this bug might be related to #wave-control
IuliiaHerets commentedon Sep 25, 2024
@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
hungvu193 commentedon Sep 26, 2024
Edited by proposal-police: This proposal was edited at 2024-09-26 02:19:00 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
NetSuite - "Can't connect to NetSuite" message appears after connecting
What is the root cause of that problem?
In here, we're showing the error if
policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === false, this logic was added to show the authentication error if the user enters the wrong credentials in this PR (#47059). However, this logic is redundant since we already have a condition to check wrong credentials right before this block here:App/src/pages/workspace/accounting/utils.tsx
Line 260 in 3488695
Because of that, when 2 Pusher events arrived later. We will briefly see the error because the connection object contains
verified: falseand the other containsverified: true.What changes do you think we should make in order to solve the problem?
Remove
policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === falsefrom this condition since it's redundant.After that, we also need to update
hasSynchronizationErrorMessageto handle the logic of showing RBR as well.What alternative solutions did you explore? (Optional)
As I checked, the response of NetSuite connection is almost the same as other connections, we can consider removing this condition and handling Netsuite like other connections.
We also need to update
hasSynchronizationErrorMessageto handle the logic of showing RBR as well.layacat commentedon Sep 30, 2024
How do I get the NetSuite credentials?
sonialiap commentedon Sep 30, 2024
Checking if we have test credentials
layacat commentedon Sep 30, 2024
Thank you!
[-]NetSuite - "Can't connect to NetSuite" message appears after connecting[/-][+][$250] NetSuite - "Can't connect to NetSuite" message appears after connecting[/+]melvin-bot commentedon Sep 30, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021840815188552877987
19 remaining items
melvin-bot commentedon Oct 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sonialiap commentedon Oct 14, 2024
Payment summary:
Ollyws commentedon Oct 14, 2024
BugZero Checklist:
#47059
#47059 (comment)
N/A
Yes.
Regression Test Proposal
Do we agree 👍 or 👎
Ollyws commentedon Oct 14, 2024
Requested in ND.
melvin-bot commentedon Oct 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
garrettmknight commentedon Oct 15, 2024
$250 approved for @Ollyws
garrettmknight commentedon Oct 15, 2024
$250 approved for @hungvu193