Skip to content

[HOLD for payment 2024-10-14] [$250] NetSuite - "Can't connect to NetSuite" message appears after connecting #49752

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48918
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new Gmail account
  3. Click on FAB - New workspace
  4. Enable "Accounting" in the "More features" page.
  5. Navigate to "Accounting"
  6. Connect to NetSuite and upgrade the workspace to Control when asked
  7. Wait for the sync to finish

Expected Result:

There shouldn't be any error messages.

Actual Result:

"Can't connect to NetSuite" message appears after connecting.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6615201_1727293693434.bandicam_2024-09-25_21-41-33-738.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021840815188552877987
  • Upwork Job ID: 1840815188552877987
  • Last Price Increase: 2024-09-30
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 25, 2024
  2. melvin-bot commented on Sep 25, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Sep 25, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-control

  4. IuliiaHerets commented on Sep 25, 2024

    @IuliiaHerets
    Author

    @sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. hungvu193 commented on Sep 26, 2024

    @hungvu193
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-09-26 02:19:00 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    NetSuite - "Can't connect to NetSuite" message appears after connecting

    What is the root cause of that problem?

    In here, we're showing the error if policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === false, this logic was added to show the authentication error if the user enters the wrong credentials in this PR (#47059). However, this logic is redundant since we already have a condition to check wrong credentials right before this block here:

    if (isAuthenticationError(policy, connectionName)) {

    Because of that, when 2 Pusher events arrived later. We will briefly see the error because the connection object contains verified: false and the other contains verified: true.

    Screenshot 2024-09-26 at 09 05 48

    What changes do you think we should make in order to solve the problem?

    Remove policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === false from this condition since it's redundant.

    After that, we also need to update hasSynchronizationErrorMessage to handle the logic of showing RBR as well.

    What alternative solutions did you explore? (Optional)

    As I checked, the response of NetSuite connection is almost the same as other connections, we can consider removing this condition and handling Netsuite like other connections.
    We also need to update hasSynchronizationErrorMessage to handle the logic of showing RBR as well.

  6. layacat commented on Sep 30, 2024

    @layacat
    Contributor

    How do I get the NetSuite credentials?

  7. sonialiap commented on Sep 30, 2024

    @sonialiap
    Contributor

    Checking if we have test credentials

  8. layacat commented on Sep 30, 2024

    @layacat
    Contributor

    Thank you!

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 30, 2024
  10. changed the title [-]NetSuite - "Can't connect to NetSuite" message appears after connecting[/-] [+][$250] NetSuite - "Can't connect to NetSuite" message appears after connecting[/+] on Sep 30, 2024
  11. melvin-bot commented on Sep 30, 2024

    @melvin-bot
  12. 19 remaining items

  13. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @hungvu193 requires payment through NewDot Manual Requests
  15. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws / @hungvu193] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws / @hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws / @hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws / @hungvu193] Determine if we should create a regression test for this bug.
    • [@Ollyws / @hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. sonialiap commented on Oct 14, 2024

    @sonialiap
    Contributor

    Payment summary:

    • @Ollyws $250 please request in ND. Looks like you were the C+ on this one so the checklist is yours 🙏
    • @hungvu193 $250 please request in ND
  17. Ollyws commented on Oct 14, 2024

    @Ollyws
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR:

    #47059

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #47059 (comment)

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • Determine if we should create a regression test for this bug.

    Yes.

    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Login with any account.
    2. Create a new WS.
    3. Go to that workspace setting => More Features => Enable Accounting feature.
    4. Go to Accounting, click NetSuite.
    5. Enter NetSuite credentials.
    6. Verify you can connect with NetSuite without any issue.
    

    Do we agree 👍 or 👎

  18. Ollyws commented on Oct 14, 2024

    @Ollyws
    Contributor

    Requested in ND.

  19. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@sonialiap)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1840815188552877987/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  20. garrettmknight commented on Oct 15, 2024

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

  21. garrettmknight commented on Oct 15, 2024

    @garrettmknight
    Contributor

    $250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions