[HOLD for payment 2024-11-11] [$250] Held expense-Negative amount in transaction thread for held expense after paying unheld expense

@OfstadC

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49463
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
[User A] Submit two expenses to User B.
[User A] Hold one of the expenses.
[User B] Go offline.
[User B] Pay the unheld expense.
[User B] Click on the expense preview of the held expense in the main chat.

Expected Result:

The amount in the transaction thread will not be negative.

Actual Result:

The amount in the transaction thread is negative.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6615322_1727299431457.20240926_051632.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021841126678085530276
Upwork Job ID: 1841126678085530276
Last Price Increase: 2024-10-15
Automatic offers:

Nodebrute | Contributor | 104483850

Issue Owner

Current Issue Owner: @OfstadC

@OfstadC

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 1

@OfstadC

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-10-09 18:11:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Negative amount in transaction thread for held expense after paying unheld expense

What is the root cause of that problem?

For expense report case we add - before amount because the amounts are stored using an opposite sign

App/src/libs/TransactionUtils/index.ts

Lines 345 to 351 in b655040

    
           // Expense report case: 
        
           // The amounts are stored using an opposite sign and negative values can be set, 
        
           // we need to return an opposite sign than is saved in the transaction object 
        
           let amount = transaction?.modifiedAmount ?? 0; 
        
           if (amount) { 
        
               return -amount; 
        
           }

However, when we handle the pay money request and use getReportFromHoldRequestsOnyxData, we are actually creating an ExpenseReport. For 1:1 direct messages, it should instead be an IOUReport.

App/src/libs/actions/IOU.ts

Lines 6451 to 6459 in b655040

    
           const optimisticExpenseReport = ReportUtils.buildOptimisticExpenseReport( 
        
               chatReport.reportID, 
        
               chatReport.policyID ?? iouReport?.policyID ?? '', 
        
               recipient.accountID ?? 1, 
        
               holdTransactions.reduce((acc, transaction) => acc + transaction.amount, 0) * (ReportUtils.isIOUReport(iouReport) ? 1 : -1), 
        
               getCurrency(firstHoldTransaction), 
        
               false, 
        
               newParentReportActionID, 
        
           );

This is also not consistent with the BE response in case of 1:1 DMs the backend will return an IOUReport

What changes do you think we should make in order to solve the problem?

We should add a check here isPolicyExpenseChat. The idea is that if it's a policy expense chat, we should build an optimistic expense report using buildOptimisticExpenseReport. If it's not a policy expense chat, then we should build an optimistic IOU report using buildOptimisticIOUReport. This is the same logic we are using here Pseudocode

 const optimisticExpenseReport = isPolicyExpenseChat
        ? ReportUtils.buildOptimisticExpenseReport(
              chatReport.reportID,
              chatReport.policyID ?? iouReport?.policyID ?? '',
              recipient.accountID ?? 1,
              totalAmount,
              getCurrency(firstHoldTransaction),
              false,
              newParentReportActionID,
          )
        : ReportUtils.buildOptimisticIOUReport(recipient.accountID ?? 1, iouReport?.managerID ?? 1, totalAmount, chatReport.reportID, getCurrency(firstHoldTransaction), false);

After this change, this line will evaluate to false, and we'll move to this block, where we'll apply -amount, which will fix the bug

App/src/libs/TransactionUtils/index.ts

Line 337 in b655040

if (!isFromExpenseReport || isFromTrackedExpense) {

Note: This is pseudocode only. We need to test the implementation with multiple test cases, which can be done in the pull request (PR).

What alternative solutions did you explore? (Optional)

We can use buildOptimisticIOUReport here instead of buildOptimisticExpenseReport

Missed this yesterday - reviewing now

@OfstadC

@OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

I had issues reproducing this on Friday - forgot to add a comment here.

Able to reproduce

20241001_220541.mp4

Reviewing label has been removed, please complete the "BugZero Checklist".

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix negative amount #51122

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment through NewDot Manual Requests
@Nodebrute requires payment automatic offer (Contributor)

@hungvu193

@hungvu193 @OfstadC The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@hungvu193

Commenting to please Melly Melvin. @hungvu193 Please ensure BZ checklist is completed by payment date. Thank you!

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/42573/files#r1836147530

If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A

If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again: We already created some tests to prevent this case, I don't think we need regression test for this one.

@hungvu193

Payment Summary

@hungvu193 due $250 via manual New Expensify request
@Nodebrute paid $250 via Upwork

@hungvu193

$250 approved for @hungvu193

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-11] [$250] Held expense-Negative amount in transaction thread for held expense after paying unheld expense #49754

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

36 remaining items

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Expense report case:
	// The amounts are stored using an opposite sign and negative values can be set,
	// we need to return an opposite sign than is saved in the transaction object
	let amount = transaction?.modifiedAmount ?? 0;
	if (amount) {
	return -amount;
	}

	const optimisticExpenseReport = ReportUtils.buildOptimisticExpenseReport(
	chatReport.reportID,
	chatReport.policyID ?? iouReport?.policyID ?? '',
	recipient.accountID ?? 1,
	holdTransactions.reduce((acc, transaction) => acc + transaction.amount, 0) * (ReportUtils.isIOUReport(iouReport) ? 1 : -1),
	getCurrency(firstHoldTransaction),
	false,
	newParentReportActionID,
	);

[HOLD for payment 2024-11-11] [$250] Held expense-Negative amount in transaction thread for held expense after paying unheld expense #49754

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 25, 2024

IuliiaHerets commented on Sep 25, 2024

IuliiaHerets commented on Sep 25, 2024

Nodebrute commented on Sep 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

OfstadC commented on Sep 27, 2024

melvin-bot commented on Sep 30, 2024

OfstadC commented on Oct 1, 2024

m-natarajan commented on Oct 1, 2024

36 remaining items

melvin-bot commented on Nov 4, 2024

melvin-bot commented on Nov 4, 2024

melvin-bot commented on Nov 4, 2024

OfstadC commented on Nov 5, 2024

hungvu193 commented on Nov 11, 2024

OfstadC commented on Nov 11, 2024

Payment Summary

garrettmknight commented on Nov 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions