You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-29] [$250] [Dupe Detection] Unable to resolve duplicates on one-expense reporrts #49793
changed the title [-]Unable to resolve duplicates on one-expense reporrts[/-][+][$250] Unable to resolve duplicates on one-expense reporrts[/+]on Sep 26, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Sep 26, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Sep 26, 2024
Edited by proposal-police: This proposal was edited at 2024-09-26 15:28:39 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The approver is unable to resolve the duplicate, as no resolve duplicate button appears
What is the root cause of that problem?
New feature
What changes do you think we should make in order to solve the problem?
In
MoneyReportHeaderuseisDuplicateto detect the duplicated transaction same as what we did in MoneyRequestHeaderthen show the
Review duplicatesbutton in hereWe should add the marginRight if there's at least one button on the right side
What alternative solutions did you explore? (Optional)
Result
Screen.Recording.2024-10-02.at.10.21.36.mov
dannymcclain commentedon Sep 26, 2024
One way we could handle this is by adding a

Resolve duplicatesbutton to the header, like so:cc @JmillsExpensify @Expensify/design
[-]Unable to resolve duplicates on one-expense reporrts[/-][+][$250] Unable to resolve duplicates on one-expense reporrts[/+]melvin-bot commentedon Sep 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021839321413603387914
melvin-bot commentedon Sep 26, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)JmillsExpensify commentedon Sep 26, 2024
Nice, I like that idea!
daledah commentedon Sep 26, 2024
Updated proposal to fit with the new design
40 remaining items
melvin-bot commentedon Oct 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 29, 2024
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Oct 31, 2024
@pecanoro, @mallenexpensify, @sobitneupane, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Nov 4, 2024
@pecanoro, @mallenexpensify, @sobitneupane, @daledah Still overdue 6 days?! Let's take care of this!
mallenexpensify commentedon Nov 5, 2024
@daledah , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021853927916382654201
@sobitneupane , plz fill out the BZ checklist above, I imagine we want a test case for this
daledah commentedon Nov 6, 2024
@mallenexpensify Many thanks, job accepted
sobitneupane commentedon Nov 6, 2024
Regression Test Proposal
Do we agree 👍 or 👎
sobitneupane commentedon Nov 6, 2024
#40153
#40153 (comment)
Yes.
#49793 (comment)
mallenexpensify commentedon Nov 7, 2024
Contributor: @daledah paid $250 via Upwork
Contributor+: @sobitneupane owed $250 via NewDot
Test case created
Thanks!
garrettmknight commentedon Dec 12, 2024
$250 approved for @sobitneupane