[HOLD for payment 2024-10-14] [$250] [Search v1.2] Optimistically update search page when bulk holding/unholding expenses

@jjcoffee

Coming from here:

Just to note that a separate issue should be opened for the bulk action dropdown not updating, i.e. following these steps:

Select any unheld outstanding expense
Tap on the bulk action dropdown and select the option to Hold the expense
Open the bulk action dropdown again
Note that it still says Hold instead of Unhold

cc @jjcoffee @cretadn22

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021839331369548391692
Upwork Job ID: 1839331369548391692
Last Price Increase: 2024-09-26

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jjcoffee

@jjcoffee For this bug, we're not resetting the selectedTransaction data in the search context when the new value is updated, resulting in outdated information.
My solution is to reset the selected transaction whenever the user clicks the hold/unhold option.

@jjcoffee @luacmartins

Job added to Upwork: https://www.upwork.com/jobs/~021839331369548391692

@jjcoffee

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Updated selected transaction If getting new updates #49829

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

@jjcoffee requires payment (Needs manual offer from BZ)
@cretadn22 requires payment (Needs manual offer from BZ)

@jjcoffee

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified. Link to the PR: N/A - this is a followup
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

On the search page, select any unheld outstanding expense
Tap on the bulk action dropdown and select the Hold option
Open the bulk action dropdown again
Verify that the available option is now Unhold

Do we agree 👍 or 👎

@jjcoffee

Payment Summary

Upwork Job

ROLE: @jjcoffee paid $250 via Upwork (LINK)
ROLE: @cretadn22 paid $250 via Upwork (LINK)

BugZero Checklist (@trjExpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1839331369548391692/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Offers sent to you both!

@trjExpensify

@trjExpensify Thanks, offer accepted!

@jjcoffee

@jjcoffee, paid!

@trjExpensify

@trjExpensify Offer accepted

Paid, closing!

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-14] [$250] [Search v1.2] Optimistically update search page when bulk holding/unholding expenses #49795

13 remaining items

Payment Summary

BugZero Checklist (@trjExpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-14] [$250] [Search v1.2] Optimistically update search page when bulk holding/unholding expenses #49795

Description

Activity

melvin-bot commented on Sep 26, 2024

cretadn22 commented on Sep 26, 2024

melvin-bot commented on Sep 26, 2024

13 remaining items

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 7, 2024

jjcoffee commented on Oct 14, 2024

melvin-bot commented on Oct 14, 2024

Payment Summary

BugZero Checklist (@trjExpensify)

trjExpensify commented on Oct 15, 2024

jjcoffee commented on Oct 15, 2024

trjExpensify commented on Oct 15, 2024

cretadn22 commented on Oct 15, 2024

trjExpensify commented on Oct 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions