You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-14] [Search v2.4] Update from, to, in, cardID, taxRate filters to accept names in addition to IDs #49846
Coming from here, we need to update the Search AST algorithm to accept more than just IDs for the from, to, in, cardID and taxRate filters given that Onyx might not have this values locally to replace the names with the appropriate IDs.
Solution
Update the server algorithm that parses the Search AST to handle names in addition to IDs
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Sep 27, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 27, 2024
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.
13 remaining items
melvin-bot commentedon Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 7, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ikevin127 commentedon Oct 11, 2024
No need for regression tests here as stated before in #46031 (comment):
melvin-bot commentedon Oct 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@JmillsExpensify)
ikevin127 commentedon Oct 15, 2024
cc @JmillsExpensify for payment
melvin-bot commentedon Oct 17, 2024
@JmillsExpensify, @luacmartins, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!
JmillsExpensify commentedon Oct 17, 2024
Payment summary: $250 to @ikevin127 for PR testing and review.
JmillsExpensify commentedon Oct 17, 2024
All paid out and not regression test. Closing this out!