Skip to content

[HOLD for payment 2024-10-14] [Search v2.4] Update from, to, in, cardID, taxRate filters to accept names in addition to IDs #49846

Closed

Description

@luacmartins

Problem

Coming from here, we need to update the Search AST algorithm to accept more than just IDs for the from, to, in, cardID and taxRate filters given that Onyx might not have this values locally to replace the names with the appropriate IDs.

Solution

Update the server algorithm that parses the Search AST to handle names in addition to IDs

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 27, 2024
  2. self-assigned this
    on Sep 27, 2024
  3. melvin-bot commented on Sep 27, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added
    NewFeatureSomething to build that is a new item.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 27, 2024
  5. melvin-bot commented on Sep 27, 2024

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  6. moved this to Release 3: Fall 2024 (Nov) in #expensify-bugson Sep 27, 2024
  7. added
    InternalRequires API changes or must be handled by Expensify staff
    on Sep 27, 2024
  8. 13 remaining items

  9. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  11. ikevin127 commented on Oct 11, 2024

    @ikevin127
    Contributor
    • [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

    No need for regression tests here as stated before in #46031 (comment):

    This feature is still WIP, so we'll add them as part of the project wrap up.

  12. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @ikevin127 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@JmillsExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. ikevin127 commented on Oct 15, 2024

    @ikevin127
    Contributor

    cc @JmillsExpensify for payment

  14. melvin-bot commented on Oct 17, 2024

    @melvin-bot

    @JmillsExpensify, @luacmartins, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. JmillsExpensify commented on Oct 17, 2024

    @JmillsExpensify
    Contributor

    Payment summary: $250 to @ikevin127 for PR testing and review.

  16. JmillsExpensify commented on Oct 17, 2024

    @JmillsExpensify
    Contributor

    All paid out and not regression test. Closing this out!

  17. moved this from Release 3: Fall 2024 (Nov) to Done in #expensify-bugson Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions