Book travel -App reopens company address page instead of T&C page after saving company address

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+salalalala@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Open FAB > Book travel
Click Book travel
Select address and save it
Click Book travel

Expected Result:

App will redirect to T&C page

Actual Result:

App reopens company address page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6617726_1727463541833.20240928_023429.mp4

View all open jobs on GitHub

@AndrewGable

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #vip-travel

Most probably coming from this one -> https://github.com/Expensify/App/pull/48060/files

Proposal

Please re-state the problem that we are trying to solve in this issue.

App reopens company address page instead of T&C page after saving company address

What is the root cause of that problem?

We are checking for isEmptyObject(travelSettings)

App/src/libs/TripReservationUtils.ts

Lines 81 to 83 in 71db3f1

    
           if (isEmptyObject(travelSettings)) { 
        
               Navigation.navigate(ROUTES.WORKSPACE_PROFILE_ADDRESS.getRoute(activePolicyID ?? '-1', Navigation.getActiveRoute())); 
        
               return;

What changes do you think we should make in order to solve the problem?

We should check if !hasPolicyAddress only then we should navigate to address page

App/src/libs/TripReservationUtils.ts

Lines 81 to 83 in 71db3f1

    
           if (isEmptyObject(travelSettings)) { 
        
               Navigation.navigate(ROUTES.WORKSPACE_PROFILE_ADDRESS.getRoute(activePolicyID ?? '-1', Navigation.getActiveRoute())); 
        
               return;

    const hasPolicyAddress = !isEmptyObject(policy?.address);
   if (!hasPolicyAddress) {
        Navigation.navigate(ROUTES.WORKSPACE_PROFILE_ADDRESS.getRoute(activePolicyID ?? '-1', Navigation.getActiveRoute()));
        return;
    }

We can pass policy to this function

What alternative solutions did you explore? (Optional)

@daledah

cc @daledah @luacmartins @DylanDylann

@AndrewGable

@AndrewGable Here's the follow-up PR

Book Travel is behind a beta - not sure if it needs to be a blocker but the solution looks simple. Looks like we have a good number of customers on the beta, so if we can fix it that'd probably be best.

Fixed in staging. Closing.

Navigation Menu

Repository navigation

Book travel -App reopens company address page instead of T&C page after saving company address #49870

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isEmptyObject(travelSettings)) {
	Navigation.navigate(ROUTES.WORKSPACE_PROFILE_ADDRESS.getRoute(activePolicyID ?? '-1', Navigation.getActiveRoute()));
	return;

Book travel -App reopens company address page instead of T&C page after saving company address #49870

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 27, 2024

github-actions commented on Sep 27, 2024

lanitochka17 commented on Sep 27, 2024

ishpaul777 commented on Sep 27, 2024

Nodebrute commented on Sep 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

AndrewGable commented on Sep 27, 2024

daledah commented on Sep 28, 2024

roryabraham commented on Sep 29, 2024

luacmartins commented on Sep 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions