Expense - Incorrectly fallback avatar is shown for split expense

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Launch app
Tap on a workspace chat
Create a manual split expense
Note the avatar of split expense

Expected Result:

Fall back avatar musn't be shown for split expense

Actual Result:

Incorrectly fallback avatar is shown for split expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6617843_1727469195403.Screenrecorder-2024-09-28-01-57-12-949_compress_1.mp4

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@tgolen

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrectly fallback avatar is shown for split expense

What is the root cause of that problem?

The fallback avatar is showing in the split expense due to this condition check.

App/src/pages/home/report/ReportActionsListItemRenderer.tsx

Line 176 in 3047c1b

CONST.REPORT.ACTIONS.TYPE.IOU,

What changes do you think we should make in order to solve the problem?

We should remove CONST.REPORT.ACTIONS.TYPE.IOU for it to work as expected in this ticket. Something like this:

shouldShowSubscriptAvatar={
                (ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isInvoiceRoom(report)) &&
                [
-                    CONST.REPORT.ACTIONS.TYPE.IOU,
                    CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW,
                    CONST.REPORT.ACTIONS.TYPE.SUBMITTED,
                    CONST.REPORT.ACTIONS.TYPE.APPROVED,
                    CONST.REPORT.ACTIONS.TYPE.FORWARDED,
                ].some((type) => type === reportAction.actionName)
            }

Details

POC

Screen.Recording.2024-09-29.at.22.43.20.mp4

Seems to be a frontend issue, so not a Web-E blocker

@grgia

@grgia It looks like this is probably a regression from #49172. Would you be able to take a look at this?

Looking, but I think the problem is that two reports are created? this is the split in new dot for me, I don't see a submit button

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@grgia

We reverted the problematic PR #49945. Gonna remove the label but keep this open so @grgia can fix this in a followup.

@grgia

This issue has not been updated in over 15 days. @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Need to retest this one

@grgia

@grgia, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Navigation Menu

Repository navigation

Expense - Incorrectly fallback avatar is shown for split expense #49884

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

2 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Expense - Incorrectly fallback avatar is shown for split expense #49884

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Sep 28, 2024

melvin-bot commented on Sep 28, 2024

huult commented on Sep 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Gonals commented on Sep 30, 2024

tgolen commented on Sep 30, 2024

grgia commented on Sep 30, 2024

2 remaining items

melvin-bot commented on Sep 30, 2024

melvin-bot commented on Sep 30, 2024

jasperhuangg commented on Sep 30, 2024

melvin-bot commented on Oct 31, 2024

grgia commented on Nov 29, 2024

melvin-bot commented on Jan 27, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions