Expense - Unable to drag and drop receipt to Upload receipt RHP

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to DM
Submit an expense without receipt
Go to transaction thread
Click on Add receipt modal
Drag and drop an image to the RHP

Expected Result:

Image can be dragged and dropped to Upload receipt RHP

Actual Result:

Image cannot be dragged and dropped to Upload receipt RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6618334_1727525236867.20240928_200433.mp4

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@carlosmiceli

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

We think that this bug might be related to #wave-control

offending PR #47990

Edited by proposal-police: This proposal was edited at 2024-09-29 20:15:28 UTC.

Edits: Fix code links, added video

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to drag and drop receipt to Upload receipt RHP

What is the root cause of that problem?

here we are explictly disable the drag and drop functionality when backTo route is not available.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 698 in 3047c1b

shouldShowWrapper={!!backTo}

in this PR #47990, we replaced getActiveRouteWithoutParams with getReportRHPActiveRoute which return empty string when report is not in RHP.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 538 in 3047c1b

Navigation.getReportRHPActiveRoute(),

What changes do you think we should make in order to solve the problem?

Here, If getReportRHPActiveRoute return empty string then we should get the active route from getActiveRouteWithoutParams.

                      Navigation.navigate(
                                ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
                                   // rest of params
                                    Navigation.getReportRHPActiveRoute() || Navigation.getActiveRouteWithoutParams(),
                                ),
                            )

Screen.Recording.2024-09-30.at.1.47.38.AM.mov

Edited by proposal-police: This proposal was edited at 2024-09-29 20:25:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to drag and drop receipt to Upload receipt RHP

What is the root cause of that problem?

We recently started using Navigation.getReportRHPActiveRoute() everywhere, but this issue only happens on Scan page

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 698 in 3047c1b

shouldShowWrapper={!!backTo}

It's because shouldShowWrapper will be false and the top part will be cut off

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 698 in 3047c1b

shouldShowWrapper={!!backTo}

What changes do you think we should make in order to solve the problem?

We can create a new variable const isEditing = action === CONST.IOU.ACTION.EDIT and we can pass it here

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 698 in 3047c1b

shouldShowWrapper={!!backTo}

            shouldShowWrapper={isEditing}

Optional: We can also fix this in IOURequestStepScan/index.native.tsx file
We should check for other pages too where we have this issue and fix it

What alternative solutions did you explore? (Optional)

Or we can do something like this here

         shouldShowWrapper={!!backTo || isEditing}

Alternative 2
Pass shouldShowWrapper here

 shouldShowWrapper

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 698 in 3047c1b

shouldShowWrapper={!!backTo}

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android- expense - In camera screen receipt header is missing

What is the root cause of that problem?

The backTo is undefined, which prevents the wrapper from showing and causes this issue.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 698 in 3634670

shouldShowWrapper={!!backTo}

backTo is undefined because Navigation.getReportRHPActiveRoute() returns undefined when clicked from the money request view.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 538 in 3047c1b

Navigation.getReportRHPActiveRoute(),

What changes do you think we should make in order to solve the problem?

We should check if getReportRHPActiveRoute returns undefined, and if so, use getActiveRouteWithoutParams.

// src/components/ReportActionItem/MoneyRequestView.tsx#L538
{shouldShowReceiptEmptyState && (
                    <ReceiptEmptyState
                        hasError={hasErrors}
                        disabled={!canEditReceipt}
                        onPress={() =>
                            Navigation.navigate(
                                ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
                                    CONST.IOU.ACTION.EDIT,
                                    iouType,
                                    transaction?.transactionID ?? '-1',
                                    report?.reportID ?? '-1',
-                                    Navigation.getReportRHPActiveRoute(),
+                                    Navigation.getReportRHPActiveRoute() || Navigation.getActiveRouteWithoutParams(),
                                ),
                            )
                        }
                    />
                )}

What alternative solutions did you explore? (Optional)

We used getActiveRouteWithoutParams instead of getReportRHPActiveRoute.

// src/components/ReportActionItem/MoneyRequestView.tsx#L538
{shouldShowReceiptEmptyState && (
                    <ReceiptEmptyState
                        hasError={hasErrors}
                        disabled={!canEditReceipt}
                        onPress={() =>
                            Navigation.navigate(
                                ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
                                    CONST.IOU.ACTION.EDIT,
                                    iouType,
                                    transaction?.transactionID ?? '-1',
                                    report?.reportID ?? '-1',
-                                    Navigation.getReportRHPActiveRoute(),
+                                    Navigation.getActiveRouteWithoutParams(),
                                ),
                            )
                        }
                    />
                )}

Note: Same as my proposal posted previously.

Details

POC

Not a Web-E blocker

@bernhardoj

I think @bernhardoj already fixed this here? Should I assign you to this one? I don't think this should be weekly btw, I'll change it to Hourly until we confirm this is solved today since it's a rough bug.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@carlosmiceli

@carlosmiceli yes, I'm fixing it in #49916. Not sure if I need to get assigned here though.

The linked PR fixes this blocker and is ready for merging and cherry-picking to staging

@luacmartins

Since @luacmartins is reviewing that PR I'll let him decide, should @bernhardoj be assigned to this issue too?

Confirmed fix on staging.

This was a regression so I'm gonna close the issue.

Navigation Menu

Repository navigation

Expense - Unable to drag and drop receipt to Upload receipt RHP #49901

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Expense - Unable to drag and drop receipt to Upload receipt RHP #49901

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Sep 29, 2024

melvin-bot commented on Sep 29, 2024

lanitochka17 commented on Sep 29, 2024

ishpaul777 commented on Sep 29, 2024

ishpaul777 commented on Sep 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Nodebrute commented on Sep 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

huult commented on Sep 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Gonals commented on Sep 30, 2024

carlosmiceli commented on Sep 30, 2024

melvin-bot commented on Sep 30, 2024

bernhardoj commented on Sep 30, 2024

rayane-d commented on Sep 30, 2024

carlosmiceli commented on Sep 30, 2024

luacmartins commented on Sep 30, 2024

luacmartins commented on Sep 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions