[HOLD for payment 2024-12-03] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state

@quinthar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1727449830031979

Action Performed:

Have a long chat with User B
As User A, access the chat on your device so it’s cached and kill the app
As User B, message User A
As User A, tap on the notification for the message.

Expected Result:

The full cached chat should be opened, potentially minus the most recent message.

Actual Result:

A skeleton page loads, indicating the app is reloading the chat from scratch rather than using the cache.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

screen-20240930-073210.mp4

Profile_trace_for_9.0.41-2.cpuprofile

logs-2024-09-30 14_32_20.691.txt

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021844432440110156078
Upwork Job ID: 1844432440110156078
Last Price Increase: 2024-10-10

Issue Owner

Current Issue Owner: @eVoloshchak

@Beamanator

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Maybe we can make this Weekly since it's not reproducible yet?

@eVoloshchak

Payment Summary

Upwork Job

Reviewer: @eVoloshchak owed $250 via NewDot
Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@garrettmknight)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1844432440110156078/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@eVoloshchak

@eVoloshchak can you complete the checklist?

@garrettmknight

@garrettmknight, @eVoloshchak, @Julesssss, @stitesExpensify, @jnowakow Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

The PR that introduced the bug has been identified. Link to the PR: [HybridApp] Share auth token in HybridApp #48007
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48007/files#r1877981836
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not sure if additional discussion is needed, this is a simple visual bug

Regression Test Proposal

Have a long chat with User B
As User A, access the chat on your device so it’s cached and kill the app
As User B, message User A
As User A, tap on the notification for the message.
Observe that there are no loading skeletons for previous messages

Do we agree 👍 or 👎

@eVoloshchak

@eVoloshchak please request from ND.

@eVoloshchak

$250 approved for @eVoloshchak

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-03] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state #49964

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

103 remaining items

Payment Summary

BugZero Checklist (@garrettmknight)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-12-03] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state #49964

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 1, 2024

melvin-bot commented on Oct 1, 2024

MelvinBot commented on Oct 1, 2024

Beamanator commented on Oct 1, 2024

103 remaining items

melvin-bot commented on Dec 3, 2024

Payment Summary

BugZero Checklist (@garrettmknight)

garrettmknight commented on Dec 6, 2024

melvin-bot commented on Dec 10, 2024

eVoloshchak commented on Dec 10, 2024

garrettmknight commented on Dec 12, 2024

JmillsExpensify commented on Jan 14, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions