iOS - Composer - No copy paste option in edit mode

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0..42-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+zm27@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to DM.
Long tap on any message.
Tap Edit comment.
Tap on the composer to bring up context menu.

Expected Result:

There will be copy paste option in edit mode.

Actual Result:

There is no copy paste option in edit mode.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6620895_1727771529331.no_copy_no_paste_.mp4

View all open jobs on GitHub

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@iwiznia

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Regression from: #32711

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Composer - No copy paste option in edit mode

What is the root cause of that problem?

We recently introduce the logic of hiding context menu for Composer text input with contextMenuHidden in #32711

We already implemented it for the main composer however we forgot to implement onTouchStart for the composer of ReportActionItemMessageEdit which makes the showSoftInputOnFocus is always undefined and because of that the condition inside native composer is never called:

    useEffect(() => {
        if (!showSoftInputOnFocus || !isKeyboardShown) {
            return;
        }
        setContextMenuHidden(false);
    }, [showSoftInputOnFocus, isKeyboardShown]);

What changes do you think we should make in order to solve the problem?

Just implement the logic of onTouchStart for the composer of ReportActionItemMessageEdit too:


     onTouchStart={() => {
                        if (showSoftInputOnFocus) {
                            return;
                        }
                        if (Browser.isMobileSafari()) {
                            setTimeout(() => {
                                setShowSoftInputOnFocus(true);
                            }, CONST.ANIMATED_TRANSITION);
                            return;
                        }
                        setShowSoftInputOnFocus(true);
                    }}

What alternative solutions did you explore? (Optional)

N/A

Retest request is here for easy access

Issue fixed

ScreenRecording_10-02-2024.01-35-36_1.MP4

Navigation Menu

Repository navigation

iOS - Composer - No copy paste option in edit mode #49977

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

iOS - Composer - No copy paste option in edit mode #49977

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 1, 2024

melvin-bot commented on Oct 1, 2024

github-actions commented on Oct 1, 2024

hungvu193 commented on Oct 1, 2024

layacat commented on Oct 1, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

jasperhuangg commented on Oct 1, 2024

m-natarajan commented on Oct 1, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions