[HOLD for payment 2024-11-14] [$250] Report Field- Report fields values do not update on system message until refresh the page

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935+223@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions: Existing workspace with report fields enabled and report fields set up

Navigate to workspace chat
Create new manual expense
Open the expense and submit it
Change Description
Change any of the report fields value
Notice the system messages for the changes
Refresh the page and notice the change in system message

Expected Result:

Report fields values update shown on system message instantly

Actual Result:

Report fields values update doesn't shown on system message instantly until refreshed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6621407_1727807730250.Letter_Edit_came_after_refresh.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021841468586674370606
Upwork Job ID: 1841468586674370606
Last Price Increase: 2024-10-02
Automatic offers:

nkdengineer | Contributor | 104262442

Issue Owner

Current Issue Owner: @mallenexpensify

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sonialiap

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields values do not update on system message until refresh the page

What is the root cause of that problem?

When we edit the report field, BE doesn't return the report field in response and we also don't create the optimistic action for the change field action.

What changes do you think we should make in order to solve the problem?

In updateReportField function, we should create an optimistic change field action follow the action that BE returns and reset it in failure data or set an error. We also need to send reportActionID of the optimistic change field action to the payload of Report_SetFields API then BE can use this ID to generate the change field action from BE.

App/src/libs/actions/Report.ts

Line 1907 in 7dde09e

    
           function updateReportField(reportID: string, reportField: PolicyReportField, previousReportField: PolicyReportField) {

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021841468586674370606

@aimane-chnaif

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@nkdengineer

@nkdengineer proposal looks good to me.
Also requires fix in BE
🎀👀🎀 C+ reviewed

Still OOO

@aimane-chnaif

@aimane-chnaif please reopen and ping me once you're back so that I can complete payment :)

@aimane-chnaif

@aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~021988044996911695723

@aimane-chnaif

Payment Summary

Contributor+: @aimane-chnaif paid $250 via Upwork

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-14] [$250] Report Field- Report fields values do not update on system message until refresh the page #50020

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

66 remaining items

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-14] [$250] Report Field- Report fields values do not update on system message until refresh the page #50020

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 1, 2024

lanitochka17 commented on Oct 1, 2024

nkdengineer commented on Oct 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Oct 2, 2024

melvin-bot commented on Oct 2, 2024

aimane-chnaif commented on Oct 2, 2024

66 remaining items

sonialiap commented on Dec 13, 2024

sonialiap commented on Dec 23, 2024

mallenexpensify commented on Nov 11, 2025

mallenexpensify commented on Nov 11, 2025

Payment Summary

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions