[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error

@isabelastisser

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+sd34@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to self DM.
Track a manual expense.
Click Submit it to someone from the actionable whisper.
Click Just track it (don’t submit it).
Click Track expense.

Expected Result:

In Step 5, the option "Just track it (don’t submit it)" should not be present when submitting track expense to someone.

Actual Result:

In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6622007_1727865495696.track_again.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mjasikowski

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Edited by proposal-police: This proposal was edited at 2024-10-02 11:27:10 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.

What is the root cause of that problem?

We are only not showing this option if the selfDMReportID is empty

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 79 in 9627f5f

const shouldDisplayTrackExpenseButton = !!selfDMReportID;

What changes do you think we should make in order to solve the problem?

We should add the check IOUUtils.isMovingTransactionFromTrackExpense to prevent showing this option if we're moving transaction from track expense

const shouldDisplayTrackExpenseButton = !!selfDMReportID && !IOUUtils.isMovingTransactionFromTrackExpense(action);

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 79 in 9627f5f

const shouldDisplayTrackExpenseButton = !!selfDMReportID;

What alternative solutions did you explore? (Optional)

Regression from #49007

Confirmed to be under combinedTrackSubmit beta, therefore not blocking

@fedirjh

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP] don't show just track it option unless coming from CREATE flow #50068

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment through NewDot Manual Requests

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fedirjh

Payment Summary

Upwork Job

Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@isabelastisser)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@isabelastisser

@isabelastisser, @fedirjh, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

I was OOO yesterday. I will review this today!

@grgia

I believe the payment summary above is incorrect. I see that @grgia assigned @fabioh8010 to review the PR, so payment should be made to @fabioh8010 only.

@grgia @fabioh8010, please confirm before I can make the payment. Thanks!

@isabelastisser

@isabelastisser I'm a contractor from an expert agency (Callstack), so no payment is required 🙂

Got it, thanks! We are all set then.

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error #50048

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

Payment Summary

BugZero Checklist (@isabelastisser)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error #50048

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 2, 2024

melvin-bot commented on Oct 2, 2024

github-actions commented on Oct 2, 2024

nkdengineer commented on Oct 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented on Oct 2, 2024

mjasikowski commented on Oct 2, 2024

23 remaining items

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 14, 2024

Payment Summary

BugZero Checklist (@isabelastisser)

melvin-bot commented on Oct 14, 2024

isabelastisser commented on Oct 15, 2024

isabelastisser commented on Oct 15, 2024

fabioh8010 commented on Oct 16, 2024

isabelastisser commented on Oct 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions